Replace keyword variable name #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This fixes another occurrence of a keyword being used as a variable name. It is allowed but is rather poor practice and makes searching for the use of keywords and constructs somewhat harder.
- The forcing diagnostics were using array syntax than meant calculations were being made for points that could be invalid (uninitialized in halos)
|
Looks good. Is the removal of array syntax meant for efficiency purposes? |
|
Removing array syntax is primarily to avoid doing work in the halo regions.
Sometimes we deliberately do not initialize the halo region so using loops
then also avoids floating point exceptions - avoiding array syntax helps
when debugging real floating point exceptions.
…--
Dr Alistair Adcroft (Alistair.Adcroft@noaa.gov)
Princeton University Tel: (609) 987-5073
NOAA/GFDL, 201 Forrestal Road, Princeton, NJ 08540
On Mon, Jul 3, 2017 at 8:12 AM, Stephen Griffies ***@***.***> wrote:
Looks good.
Is the removal of array syntax meant for efficiency purposes?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<NOAA-GFDL#542 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFlo8-HkOP6xxOV-XBzh2AH8fiJ5_dPfks5sKNqdgaJpZM4OLogh>
.
|
nikizadehgfdl
pushed a commit
to nikizadehgfdl/MOM6
that referenced
this pull request
Oct 9, 2017
- MOM_parameter_doc files updated by NOAA-GFDL/MOM6@7d401bc and NOAA-GFDL/MOM6@13541f4 - No answer changes. - NOAA-GFDL/MOM6@0192c3c Merge pull request mom-ocean#544 from adcroft/fix-hdfs-diagnostic - NOAA-GFDL/MOM6@e9f146d Merge pull request mom-ocean#542 from adcroft/replace-keyword-variable-name - NOAA-GFDL/MOM6@e05d8ae Merge pull request mom-ocean#541 from adcroft/fix-generic-tracer-MLD-arg - NOAA-GFDL/MOM6@13541f4 Merge pull request mom-ocean#540 from adcroft/mle-length-scale - NOAA-GFDL/MOM6@7d401bc Merge pull request mom-ocean#539 from adcroft/cleanup-varmix - NOAA-GFDL/MOM6@b56e593 Added "skip_diags" argument to extractFluxes1d() - NOAA-GFDL/MOM6@04116e8 Avoid allocating unused arrays in diabatic_driver - NOAA-GFDL/MOM6@0f28767 Replaced array-syntax with loops - NOAA-GFDL/MOM6@3eecc26 Replaced "sum" with "res" for variable name - NOAA-GFDL/MOM6@6e4eaa4 Fixed argument name to match declaration gen_trcr_col_physics() - NOAA-GFDL/MOM6@f733ff0 Implemented scale-aware option for MLE - NOAA-GFDL/MOM6@a110df9 Fix VarMix cleanup with openMP - NOAA-GFDL/MOM6@3e50273 Re-factor of MOM_lateral_mixing_coeffs.F90 (VarMix) - NOAA-GFDL/MOM6@a1ac57f Merge pull request mom-ocean#538 from Hallberg-NOAA/dev/gfdl - NOAA-GFDL/MOM6@fec16b9 Renamed variables "mod" to "mdl" - NOAA-GFDL/MOM6@f6bade7 Merge branch 'dev/gfdl' of github.com:NOAA-GFDL/MOM6 into dev/gfdl - NOAA-GFDL/MOM6@ebbce13 Merge branch 'dev/gfdl' of github.com:NOAA-GFDL/MOM6 into dev/gfdl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two distinct commits that both update MOM_forcing_type.F90: