Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mle length scale #540

Merged
merged 3 commits into from
Jul 5, 2017
Merged

Mle length scale #540

merged 3 commits into from
Jul 5, 2017

Conversation

adcroft
Copy link
Collaborator

@adcroft adcroft commented Jul 2, 2017

From commit msg:

  • The third paper, in the series of Fox-Kemper et al., proposed upscaling
    the buoyancy gradients from the frontal scale to the grid-scale. To date
    this has been implemented as a globally constant upscaling indicated by
    the FOX_KEMPER_ML_RESTRAT parameter. This commit implements the upscaling
    as a function of grid-spacing, 1st-baroclinic deformation radius and a
    frontal length scale parameter, MLE_FRONT_LENGTH.
  • VarMix is now passed to mixedlayer_restrat since we need VarMix%Rd_dx.
  • Updated MLE doxumentation.

adcroft added 3 commits July 1, 2017 17:08
@adcroft
Re-factor of MOM_lateral_mixing_coeffs.F90 (VarMix)
3e50273 
- VarMix was originally for a crude implementation of a Visbeck et al.
  diffusivity formula. It has become a catchall for resolution functions,
  stored slopes and length-scales. It infact has never contained an actual
  diffusivity. The meaning of the parameter USE_VARIABLE_MIXING was original
  "use Visbeck" but has really meant "allocate and calculate everything in
  this module even if not being used". This has now been cleaned up...
- USE_VARIABLE_MIXING still exists but does nothing.
  - It will be made obsolete shortly.
- Visbeck related fields (VarMix@L2v, ...) are allocated only if
  KhTh_Slope_Cff>0 or KhTr_Slope_Cff>0.
- The Eady growth rates are now allocated and calculated if
  either of Visbeck or MEKE schemes are in use.
- The field VarMix%Rd_dx_h is allocated and calculated if either the
  diagnostic is requested or the field needed "Passivity" or the
  resolution functions.
- The wave speed VarMix%cg1 is calculated only if needed but which
  includes resolution fns, Rd_dx, and FGNV stream fn.
  - Closes #522.
- Added logic in tracer_hordiff() to avoid referencing VarMix%L2v or
  VarMix%SN_v when VarMix%KhTh_Slope_Cff==0.
- Added logic in tracer_hordiff() to avoid referencing VarMix%L2v or
  VarMix%SN_v when VarMix%KhTr_Slope_Cff==0.

- This commit affects available_diags and MOM_parameter_doc for some
  experiments but does not changes answers.
@adcroft
Fix VarMix cleanup with openMP
a110df9
@adcroft
Implemented scale-aware option for MLE
f733ff0 
- The third paper, in the series of Fox-Kemper et al., proposed upscaling
  the buoyancy gradients from the frontal scale to the grid-scale. To date
  this has been implemented as a globally constant upscaling indicated by
  the FOX_KEMPER_ML_RESTRAT parameter. This commit implements the upscaling
  as a function of grid-spacing, 1st-baroclinic deformation radius and a
  frontal length scale parameter, MLE_FRONT_LENGTH.
- VarMix is now passed to mixedlayer_restrat since we need VarMix%Rd_dx.
- Updated MLE doxumentation.
@adcroft adcroft requested a review from Hallberg-NOAA July 2, 2017 01:34
adcroft
adcroft commented Jul 2, 2017
View reviewed changes
Copy link
Collaborator Author

@adcroft adcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/2064

Hallberg-NOAA
Hallberg-NOAA approved these changes Jul 5, 2017
View reviewed changes
Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change adds a new frontal lengthscale parameter that is very much in line with the original spirit of the Fox-Kemper et al. submesoscale restratification parameterizaiton.

@Hallberg-NOAA Hallberg-NOAA merged commit 13541f4 into mom-ocean:dev/gfdl Jul 5, 2017
@adcroft adcroft deleted the mle-length-scale branch July 13, 2017 01:12
@gustavo-marques gustavo-marques mentioned this pull request Jul 21, 2017
Merged
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this pull request Oct 9, 2017
@adcroft
MOM6: Multiple merges
9830339 
- MOM_parameter_doc files updated by NOAA-GFDL/MOM6@7d401bc and NOAA-GFDL/MOM6@13541f4
- No answer changes.

- NOAA-GFDL/MOM6@0192c3c Merge pull request mom-ocean#544 from adcroft/fix-hdfs-diagnostic
- NOAA-GFDL/MOM6@e9f146d Merge pull request mom-ocean#542 from adcroft/replace-keyword-variable-name
- NOAA-GFDL/MOM6@e05d8ae Merge pull request mom-ocean#541 from adcroft/fix-generic-tracer-MLD-arg
- NOAA-GFDL/MOM6@13541f4 Merge pull request mom-ocean#540 from adcroft/mle-length-scale
- NOAA-GFDL/MOM6@7d401bc Merge pull request mom-ocean#539 from adcroft/cleanup-varmix
- NOAA-GFDL/MOM6@b56e593 Added "skip_diags" argument to extractFluxes1d()
- NOAA-GFDL/MOM6@04116e8 Avoid allocating unused arrays in diabatic_driver
- NOAA-GFDL/MOM6@0f28767 Replaced array-syntax with loops
- NOAA-GFDL/MOM6@3eecc26 Replaced "sum" with "res" for variable name
- NOAA-GFDL/MOM6@6e4eaa4 Fixed argument name to match declaration gen_trcr_col_physics()
- NOAA-GFDL/MOM6@f733ff0 Implemented scale-aware option for MLE
- NOAA-GFDL/MOM6@a110df9 Fix VarMix cleanup with openMP
- NOAA-GFDL/MOM6@3e50273 Re-factor of MOM_lateral_mixing_coeffs.F90 (VarMix)
- NOAA-GFDL/MOM6@a1ac57f Merge pull request mom-ocean#538 from Hallberg-NOAA/dev/gfdl
- NOAA-GFDL/MOM6@fec16b9 Renamed variables "mod" to "mdl"
- NOAA-GFDL/MOM6@f6bade7 Merge branch 'dev/gfdl' of github.com:NOAA-GFDL/MOM6 into dev/gfdl
- NOAA-GFDL/MOM6@ebbce13 Merge branch 'dev/gfdl' of github.com:NOAA-GFDL/MOM6 into dev/gfdl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hallberg-NOAA Hallberg-NOAA Hallberg-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adcroft @Hallberg-NOAA