Changed intent for G in tidal_forcing_init() #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The recent introduction of pass_var() calls on some fields in tidal_forcing_init() should have caused compile-time errors because pass_var() requires the G%Domain argument to be intent(inout). - Very worryingly, none of the compilers on c3 complained. Nor did gnu complain on the "trusty" image but I happened to still be using the older "precise" image for testing my scripts and the compiler there caught the mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Hallberg-NOAA I am a little uneasy that all three compilers, with the newest and only versions we have on c4, happily compiled. How can all three compilers have stopped checking intents?
Commit message:
tidal_forcing_init() should have caused compile-time errors
because pass_var() requires the G%Domain argument to be intent(inout).
complain on the "trusty" image but I happened to still be using the older
"precise" image for testing my scripts and the compiler there
caught the mistake.