OBC registry #476
Merged
OBC registry #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Can use Flather on outflow end, which behaves much better than prior choice.
- Kelvin wave and tidal bay so far.
- Put back supercritical_initialize_topography as well, just in case we want to try for the shock with the land masking.
Also got shelfwave to compile.
- Oops. Rotated is too strong now?
- The BT_OBC structure still has them (probably needs some exchanges??). - Need to obsolete READ_OBC_ETA, READ_OBC_UV, and READ_OBC_TS. They aren't being used in any of our tests (speaking of coverage). - No answer change.
|
By the way, this changes answers for CCS. It does so because Matt's code loads up the segment variables while the old barotropic code was using OBC%ubt_outer instead. |
|
OK, this looks right. I'll handle the PR today. Looking at the correlation of OBC and update_OBC_CSp in arguments makes it seem that there is redundancy but as you point out, there is a circular dependency in the types themselves. Idea for the future (i.e. not needed now), we could rename things if we think of MOM_boundary_update.F90 as an "OBC driver" and the current MOM_open_boundary.F90 as the "segment provider". |
|
There might be a way to have OBC inside the update_OBC_CSp instead. Perhaps
rename it first. I agree about saving it for later though.
…On Tue, Apr 25, 2017 at 4:53 AM, Alistair Adcroft ***@***.***> wrote:
OK, this looks right. I'll handle the PR today.
Looking at the correlation of OBC and update_OBC_CSp in arguments makes it
seem that there is redundancy but as you point out, there is a circular
dependency in the types themselves. Idea for the future (i.e. not needed
now), we could rename things if we think of MOM_boundary_update.F90 as an
"OBC driver" and the current MOM_open_boundary.F90 as the "segment
provider".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<NOAA-GFDL#476 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAbIHi6QnU2Ks5xGNfhK9-_qpoaInl3_ks5rzezegaJpZM4NFhaJ>
.
|
|
Exactly, and agreed.
…--
Dr Alistair Adcroft (Alistair.Adcroft@noaa.gov)
Princeton University Tel: (609) 987-5073
NOAA/GFDL, 201 Forrestal Road, Princeton, NJ 08540
On Tue, Apr 25, 2017 at 1:19 PM, Kate Hedstrom <notifications@github.com>
wrote:
There might be a way to have OBC inside the update_OBC_CSp instead. Perhaps
rename it first. I agree about saving it for later though.
On Tue, Apr 25, 2017 at 4:53 AM, Alistair Adcroft <
***@***.***>
wrote:
> OK, this looks right. I'll handle the PR today.
>
> Looking at the correlation of OBC and update_OBC_CSp in arguments makes
it
> seem that there is redundancy but as you point out, there is a circular
> dependency in the types themselves. Idea for the future (i.e. not needed
> now), we could rename things if we think of MOM_boundary_update.F90 as an
> "OBC driver" and the current MOM_open_boundary.F90 as the "segment
> provider".
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <NOAA-GFDL#476 (comment)>, or
mute
> the thread
> <https://github.com/notifications/unsubscribe-
auth/AAbIHi6QnU2Ks5xGNfhK9-_qpoaInl3_ks5rzezegaJpZM4NFhaJ>
> .
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<NOAA-GFDL#476 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFlo8w_aa8DSnVa44zGNwOFhHY07J4p_ks5rzis4gaJpZM4NFhaJ>
.
|
marshallward
pushed a commit
to marshallward/MOM6
that referenced
this pull request
Sep 11, 2023
- This option is defaulted to False to retain previous answers,
but should be set to True for new experiments in order to make
the Flather OBC routine consistent with the barotropic solver
- This option only applies for regional OBC cases with Tides and
scalar self-attraction and loading
+ Try at fixing issue mom-ocean#476
- Will change answers for problems with OBCs.
- Get Matt's patch to compile again
Co-authored-by: Kate Hedstrom <kshedstrom@alaska.edu>
andrew-c-ross
pushed a commit
to andrew-c-ross/MOM6
that referenced
this pull request
Jul 16, 2024
- This option is defaulted to False to retain previous answers,
but should be set to True for new experiments in order to make
the Flather OBC routine consistent with the barotropic solver
- This option only applies for regional OBC cases with Tides and
scalar self-attraction and loading
+ Try at fixing issue mom-ocean#476
- Will change answers for problems with OBCs.
- Get Matt's patch to compile again
Co-authored-by: Kate Hedstrom <kshedstrom@alaska.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several things: