Collocate units and conversion for register_diag_field calls #1390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearranged arguments in register_diag_field calls to facilitate the detection
of inconsistent units and scaling factors using simple methods, by placing the
unit and conversion arguments on the same line. At some point, we will develop
more sophisticated methods for detecting such inconsistencies, at which these
changes will lose their value but become benign. Also, made use of the scaling
factor GV%H_to_MKS, which handles conversion of thickness units to m or kg m-2,
depending on whether the code is being run in Boussinesq or non-Boussinesq mode,
instead of having logic scattered in several places throughout the code to
select GV%H_to_m or GV%H_to_kg_m2. This commit closes MOM6 issue #1384. All
answers and output are bitwise identical, and these are mostly essentially
whitespace changes.