(*)Improve advective CFL calculation with tiny h #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the handling of very thin layers in make_frazil. This does not change answers for typical values of ANGSTROM, but can avoid problems that can arise when ANGSTROM=0. All answers in the existing MOM6-examples test cases are bitwise identical.
Improved handling of massless layers in the calculation of the advective CFL numbers used in PPM tracer advection by using an Adcroft reciprocal instead of adding a small value in the denominator. Although all answers are bitwise identical in the existing MOM6-examples test cases, this can avoid problems with tracer advection when ANGSTROM is 0 or very small like those that were recently found in analogous SIS2 code.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1172 +/- ##
============================================
- Coverage 46.08% 45.95% -0.14%
============================================
Files 214 224 +10
Lines 69399 70504 +1105
============================================
+ Hits 31984 32397 +413
- Misses 37415 38107 +692
Continue to review full report at Codecov.
|
|
Gaea regression testing: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/10942 Tests have passed 🎉 |
marshallward
approved these changes
Aug 8, 2020
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved handling of massless layers in the calculation of the advective CFL
numbers used in PPM tracer advection by using an Adcroft reciprocal instead of
adding a small value in the denominator. Also addressed newly exposed issues
with the handling of very thin layers in make_frazil. This does not change
answers for typical values of ANGSTROM, but can avoid problems that can arise
when ANGSTROM=0. All answers in the existing MOM6-examples test cases are
bitwise identical, and there are no changes to model output files.