Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+Adding a halo update for tracer reservoirs. #1159

Merged
merged 1 commit into from
Jul 22, 2020
Merged

+Adding a halo update for tracer reservoirs. #1159

merged 1 commit into from
Jul 22, 2020

Conversation

kshedstrom
Copy link
Collaborator

Wraps up #1130

@codecov-commenter
Copy link

Codecov Report

Merging #1159 into dev/gfdl will decrease coverage by 0.22%.
The diff coverage is 32.39%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1159      +/-   ##
============================================
- Coverage     46.08%   45.85%   -0.23%     
============================================
  Files           214      224      +10     
  Lines         69399    70084     +685     
============================================
+ Hits          31984    32139     +155     
- Misses        37415    37945     +530     
Impacted Files Coverage Δ
...g_src/external/GFDL_ocean_BGC/FMS_coupler_util.F90 0.00% <0.00%> (ø)
...fig_src/external/GFDL_ocean_BGC/generic_tracer.F90 0.00% <0.00%> (ø)
...c/external/GFDL_ocean_BGC/generic_tracer_utils.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/kdtree.f90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/ocean_da_core.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/ocean_da_types.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/write_ocean_obs.F90 0.00% <0.00%> (ø)
config_src/solo_driver/MESO_surface_forcing.F90 0.00% <0.00%> (ø)
config_src/solo_driver/MOM_driver.F90 68.72% <ø> (ø)
config_src/solo_driver/user_surface_forcing.F90 0.00% <0.00%> (ø)
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a7b3c...2a73d7d. Read the comment docs.

@Hallberg-NOAA
Copy link
Collaborator

This PR passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10859.

Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that these changes are correct and am satisfied that they will improve the restart reproducibility of MOM6.

@Hallberg-NOAA Hallberg-NOAA merged commit e55ef75 into mom-ocean:dev/gfdl Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants