Added rotated dumbbell, fixed a couple small OBC things. #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- has the potential to change answers, depending on the options used.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1045 +/- ##
===========================================
Coverage ? 45.06%
===========================================
Files ? 212
Lines ? 62624
Branches ? 0
===========================================
Hits ? 28224
Misses ? 34400
Partials ? 0
Continue to review full report at Codecov.
|
|
This PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/9505 . |
- This is perhaps redundant in that the model was already loading dudy or dvdx if they were provided. - Turns out the model was reading them, but not loading them into the segment%tangential_grad array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rotated case still does not match exactly. The barotropic solver for the tangential velocity gives microscopically different answers from find_uhbt/find_vhbt because one is positive, one is negative.