MOM6: Corrections to open boundary condition code #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added rescaling for dimensional consistency testing in MOM_open_boundary.F90, including splitting variables with different units that had previously shared the same variable and adding more extensive documentation of variables. Also changed the dimensions of the timesteps passed to radiation_open_bdry_conds and update_segment_tracer_reservoirs to [T] and added vertical_grid_type and unit_scale_type arguments to open_boundary_init and open_boundary_test_extern_h. All answers are bitwise identical, although some probably bugs have been noted in comments and there are new or altered arguments to several routines.
Corrected dimensional consistency bugs in update_segment_tracer_reservoirs and horizontal indexing and related bugs in gradient_at_q_points with oblique_grad OBCs. These will both change answers in test cases that use some open boundary condition options, but not in any of the MOM6-examples test cases.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1037 +/- ##
============================================
- Coverage 45.12% 43.53% -1.59%
============================================
Files 212 212
Lines 62486 62509 +23
============================================
- Hits 28196 27216 -980
- Misses 34290 35293 +1003
Continue to review full report at Codecov.
|
|
This PR was tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/9428, which passed. |
|
I approve this PR. |
adcroft
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pair of commits in this PR include refactoring and dimensional rescaling of the
MOM6 open boundary code, and the correction of several bugs that were revealed
in this process. This commit will change answers when certain types of OBCs
are used, but not in the existing MOM6-examples test suite. The commits in this
PR include: