Makefile: MPI flag test; REPRO flag; diff report #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes several issues with the current test suite Makefile: - the DO_REPRO_TEST flag is now available to disable the REPRO=1 test, which currently fails on older GCC compilers and Intel compilers. This may be expected, and needs further investigation. - Regression tests against PR targets had been inadvertently disabled due to a misnamed variable (TEST vs TESTS). This has been fixed. - OpenMP tests have been added to the suite. Success may vary... - We now report a full diff output for a failed cmp test of stats and diagnostic checksums - tab indentation was being used outside the context of rule definitions. This was not causing issues but has been replaced with space intents to avoid future problems. Note that OpenMP testing issues were observed on an older GCC compiler, but it's not clear if this will persist on Travis or more modern GCC compilers, and may be disabled (or perhaps even fixed) in a future commit.
|
It looks like the OpenMP tests are passing here on Travis, but do actually fail on our workstations. I'm going to put the blame on the age of our GCC compilers, but we might want to worry about this at some point. |
adcroft
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes several issues with the current test suite Makefile:
the DO_REPRO_TEST flag is now available to disable the REPRO=1 test,
which currently fails on older GCC compilers and Intel compilers.
This may be expected behavior, and needs further investigation, but for
now we make it optional.
Regression tests against PR targets had been inadvertently disabled
due to a misnamed variable (TEST vs TESTS). This has been fixed.
OpenMP tests have been added to the suite. Success may vary...
(see below).
We now report a full diff output for a failed cmp test of stats and
diagnostic checksums
tab indentation was being used outside the context of rule
definitions. This was not causing issues but has been replaced with
space indents to avoid future problems.
Note that OpenMP testing issues were observed on an older GCC compiler,
but it's not clear if this will persist on Travis or more modern GCC
compilers, and may be disabled (or perhaps even fixed) in a future
commit.