MEKE diagnostic array fixes #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the following MEKE diagnostics:
- MEKE_Ue, MEKE_Ub, MEKE_Ut
The diagnostics were computed as inline operations inside post_data,
e.g.:
post_data(..., sqrt(0, max(0., MEKE*bottomFac2)))
rather than computing the fields explicitly inside of array loops.
This case causing floating point exceptions in Intel compilers, possibly
likely due to evaluations inside of halos.
We resolve these diagnostics by computing the values into a scratch
array which is then passed to post_data.
|
Gaea regression tests: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/9086 |
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1014 +/- ##
============================================
+ Coverage 43.08% 43.09% +0.01%
============================================
Files 212 212
Lines 62230 62242 +12
============================================
+ Hits 26814 26826 +12
Misses 35416 35416
Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the following MEKE diagnostics:
The diagnostics were computed as inline operations inside post_data,
e.g.:
rather than computing the fields explicitly inside of array loops.
This case causing floating point exceptions in Intel compilers, possibly
likely due to evaluations inside of halos.
We resolve these diagnostics by computing the values into a scratch
array which is then passed to post_data.