Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need a real tree sequence type. #294

Open
molpopgen opened this issue Oct 26, 2020 · 0 comments · May be fixed by #349
Open

Need a real tree sequence type. #294

molpopgen opened this issue Oct 26, 2020 · 0 comments · May be fixed by #349

Comments

@molpopgen
Copy link
Owner

molpopgen commented Oct 26, 2020 •
edited
Loading

The tree visitor is a bit too light of a design.

We can base one on a shared pointer to a table collection.

I'd say that the table indexes should live here, too. This design would depart from tskit, but would emphasize that the indexes are for iteration.

We could keep the class light and have operations on it all be non-member?
@molpopgen molpopgen changed the title Need a real tree sequence type. (I'm not happy with the tree visitor.) Need a real tree sequence type. Oct 26, 2020
This was referenced Nov 5, 2020
Open
Open
Open
@molpopgen molpopgen mentioned this issue Jul 6, 2021
Open
@molpopgen molpopgen linked a pull request Jul 6, 2021 that will close this issue
add tree sequence #349
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add tree sequence molpopgen/fwdpp
1 participant
@molpopgen