Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AccessTokenInterface as of league/oauth2-client 2.4.0 #14

Closed
holtkamp opened this issue Nov 22, 2018 · 4 comments
Closed

Use AccessTokenInterface as of league/oauth2-client 2.4.0 #14

holtkamp opened this issue Nov 22, 2018 · 4 comments

Comments

@holtkamp
Copy link
Contributor

holtkamp commented Nov 22, 2018

league/oauth2-client 2.4.0 introduced a AccessTokenInterface.

Not using it causes an error:

PHP Fatal error:  Declaration of Mollie\OAuth2\Client\Provider\Mollie::getResourceOwnerDetailsUrl(League\OAuth2\Client\Token\AccessToken $token) must be compatible with League\OAuth2\Client\Provider\AbstractProvider::getResourceOwnerDetailsUrl(League\OAuth2\Client\Token\AccessTokenInterface $token) in /project/vendor/mollie/oauth2-mollie-php/src/Provider/Mollie.php on line 10

Forced use of league/oauth2-client 2.3.1 resolves this problem, I think this should be set as the "maximum" version of league/oauth2-client that can be used with "this" version of mollie/oauth2-mollie-php

@holtkamp holtkamp changed the title Use AccessTokenInterface as of league/oauth2-client 2.4.0 Use AccessTokenInterface as of league/oauth2-client 2.4.0 Nov 22, 2018
@holtkamp
Copy link
Contributor Author

UPDATE
This was clearly a non-backward compatible change, also discussed here: thephpleague/oauth2-client#752

@willemstuursma
Copy link
Contributor

Thanks for reporting anyway.

@ramsey
Copy link

ramsey commented Nov 22, 2018

Please check release 2.4.1 of league/oauth2-client and confirm that it fixes this issue. Thanks!

@holtkamp
Copy link
Contributor Author

@ramsey thanks for the swift patch release, this indeed resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants