Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the network variables page, the harmonisation matrix is displayed even though the selected topic and cohort have no mappings. #4343

Closed
Tracked by #4147
hslh opened this issue Oct 11, 2024 · 1 comment

Comments

@hslh
Copy link
Contributor

hslh commented Oct 11, 2024

What version of EMX2 are you using (see footer)
v11.20.0

Describe the bug
On the network variables page, the harmonisation matrix is displayed even though the selected topic and cohort have no mappings.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://emx2.dev.molgenis.org/catalogue-demo/ssr-catalogue/testNetwork1/variables'
  2. Filter on topic 'Language'
  3. Filter on source 'testCohort2'
  4. Click Harmonisations button
  5. See empty matrix is displayed

Expected behavior
No harmonisation matrix is shown, just the message 'No variables found with current filters.'

Desktop (please complete the following information):

  • OS: MacOS Sequoia, Firefox v131

Additional context
Future work: On the network variables page, the harmonisation matrix is displayed even though the selected topic and cohort have no mappings. See: /ssr-catalogue/testNetwork1/variables?page=1&conditions=[{"id":"topics","conditions":[{"name":"Language"},{"name":"Socio-demographic+and+economic+characteristics"}]},{"id":"collections","conditions":[{"name":"testCohort2"}]}]&view=harmonisation . (test 7 step 40, 46)
EDIT: in test plan 7 step 38 we just have the 'language' filter active --> 4 variables, all cohorts shown, testcohort2 has no mappings at all. Add the filter on testcohort2 --> randomly 1 variable (testVarNoRepeats) is shown (and not all 4), while the list should be empty. And in test plan 7 step 46 we have no filters active other than 1 cohort, testcohort2. 0 variables should be displayed but we get 2 seemingly random variables displayed, with no mappings (testVarNoRepeats and testVarRepeats_).

@hslh hslh changed the title Future work: On the network variables page, the harmonisation matrix is displayed even though the selected topic and cohort have no mappings. See: /ssr-catalogue/testNetwork1/variables?page=1&conditions=[{"id":"topics","conditions":[{"name":"Language"},{"name":"Socio-demographic+and+economic+characteristics"}]},{"id":"collections","conditions":[{"name":"testCohort2"}]}]&view=harmonisation . (test 7 step 40, 46) On the network variables page, the harmonisation matrix is displayed even though the selected topic and cohort have no mappings. Network1/variables?page=1&conditions=[{"id":"topics","conditions":[{"name":"Language"},{"name":"Socio-demographic+and+economic+characteristics"}]},{"id":"collections","conditions":[{"name":"testCohort2"}]}]&view=harmonisation . (test 7 step 40, 46) Oct 11, 2024
@hslh hslh changed the title On the network variables page, the harmonisation matrix is displayed even though the selected topic and cohort have no mappings. Network1/variables?page=1&conditions=[{"id":"topics","conditions":[{"name":"Language"},{"name":"Socio-demographic+and+economic+characteristics"}]},{"id":"collections","conditions":[{"name":"testCohort2"}]}]&view=harmonisation . (test 7 step 40, 46) On the network variables page, the harmonisation matrix is displayed even though the selected topic and cohort have no mappings. Oct 11, 2024
@hslh
Copy link
Contributor Author

hslh commented Oct 17, 2024

Cannot reproduce on acc (v11.20.6) nor on dev (v11.20.9), perhaps #4349 fixed this as well.

@hslh hslh closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants