Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation & Examples #1

Closed
FokkeZB opened this issue Sep 18, 2014 · 9 comments
Closed

Documentation & Examples #1

FokkeZB opened this issue Sep 18, 2014 · 9 comments

Comments

@FokkeZB
Copy link

FokkeZB commented Sep 18, 2014

Hi,

I know there's inline documentation and examples in:
https://github.com/mokesmokes/titanium-ios-facebook/blob/master/Classes/ComFacebookModule.m

But it would be nice to also have an example app.js and separate documentation.

Could you also give some details on how much of the Facebook SDK is covered?

Do you also have plans for an Android version?

@mokesmokes
Copy link
Owner

@FokkeZB I will add a readme soon, and yes, the Android module is also almost ready, will post it in a few days. When I have time I may do some examples, but that may take a while. However, the intent is for these modules to be rock solid, and my next production release will definitely use them. BTW, the current Titanium Facebook modules will be obsolete in April when Facebook kills Graph API 1.0 for good.

@FokkeZB
Copy link
Author

FokkeZB commented Sep 22, 2014

Awesome. I know @appcelerator is/was also working on updating their module and @timanrebel as well. I just hope we're not all inventing the wheel and then end up with different module API's doing the same thing :(

@mokesmokes
Copy link
Owner

@timanrebel is basing his version on my old version.... lol... I think it would be preferable if we all just cooperated on my module. My previous version worked very well in production for me, but needed to be updated of course due to all the changes at FB. This module will be in a production app on the app store very soon too. In particular, I worked a lot on the error handling, which should be quite robust by now.

@mokesmokes
Copy link
Owner

@FokkeZB
Copy link
Author

FokkeZB commented Sep 25, 2014

Awesome, but what a pain to use! ;)

Not your fault, I know. I hope https://jira.appcelerator.org/browse/TIMOB-15443 can be resolved asap

@FokkeZB FokkeZB closed this as completed Sep 25, 2014
@mokesmokes
Copy link
Owner

@FokkeZB the only thing that TIMOB-15443 will solve in Javascript is avoid needing to call the proxy during onResume. The real saving is for the person writing the module who needs to go through hoops to account for this issue. From your standpoint, all you need to do is create a proxy per activity (you will still need to do this after the issue is fixed), and then make the call to proxy.activityResumed during your activity's onResume.

@mokesmokes
Copy link
Owner

@FokkeZB see this PR tidev/titanium-sdk#6179 , once it's accepted (and I modify the Android module) all you need to do is pass lifecycleContainer: windowOrTabGroup in the proxy creation dictionary. We need to make sure this PR is accepted ASAP.

@FokkeZB
Copy link
Author

FokkeZB commented Sep 29, 2014

So every time you use the module you have to pass it the current window? That's better indeed.

@mokesmokes
Copy link
Owner

Yup, per standalone window or tabgroup you need to create the proxy object, and then the entire API works on that and not on the module object. So the chief difference between the Android and iOS versions is that in Android we have one additional call to make (per activity). The iOS version doesn't use proxies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants