Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host Logging Enhancement Optimizations #1140

Closed
10 of 18 tasks
mdebarros opened this issue Dec 23, 2019 · 0 comments
Closed
10 of 18 tasks

Host Logging Enhancement Optimizations #1140

mdebarros opened this issue Dec 23, 2019 · 0 comments
Assignees
Labels
Milestone

Comments

@mdebarros
Copy link
Member

mdebarros commented Dec 23, 2019

Goal:

As a Hub Operator, I want to logs to be optimized so that disk pressure is not an issue

Tasks:

  • Event-SDK enhancements: <-- ref work in progress branch - feature/hostLoggingEnhancement @ Mojallop remote

    • Deprecate existing env config: EVENT_SDK_SIDECAR_WITH_LOGGER
    • Add new env config: EVENT_SDK_LOG_FILTER
    • Add new env config: EVENT_SDK_LOG_METADATA_ONLY
    • Add new env config: EVENT_SDK_TRACEID_PER_VENDOR in Event SDK to switch between creating new traceId and keeping up the original one, when the vendor is external
  • Implement logging changes

    • Update all Logger output to debug on ML-API-Adapter with new Event-SDK functionality with EVENT_SDK_LOG_FILTER='audit:*, log:error, log:warning', EVENT_SDK_LOG_METADATA_ONLY='false'
    • Update all Logger output to debug on Central-Ledger with new Event-SDK functionality with EVENT_SDK_LOG_FILTER='audit:*, log:error, log:warning', EVENT_SDK_LOG_METADATA_ONLY='false'
    • Update all Logger output to debug on Event-Sidecar with new Event-SDK functionality with EVENT_SDK_LOG_FILTER=':', EVENT_SDK_LOG_METADATA_ONLY='true'
    • Update all Logger output to debug on Event-Stream-Processor with new Event-SDK functionality with EVENT_SDK_LOG_FILTER=':', EVENT_SDK_LOG_METADATA_ONLY='true'

Comment

  • We striked out Update all Logger output to debug because we can change the log filter and switch it off

  • Update Helm charts with the above config changes

    • ML-API-Adapter & Event-Sidecar
    • Central-Ledger & Event-Sidecar
  • Create new stories for:

    • Quoting Service
    • Account-Lookup-Service

Acceptance Criteria:

  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Golden Path Services (e.g. ML-API-Adapter, Central-Ledger) and supporting components log the minimum required for normal day-to-day operational monitoring.

Pull Requests:

  • TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants