Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md update #137

Closed
BarriBarri20 opened this issue Jan 9, 2023 · 4 comments
Closed

README.md update #137

BarriBarri20 opened this issue Jan 9, 2023 · 4 comments

Comments

@BarriBarri20
Copy link

BarriBarri20 commented Jan 9, 2023

Hello,

I noticed that the README.md file in this repository is not up to date. The repository github.com/mochi-co/mqtt/v2 no longer exists, and there is some missing starter code on line 84.

I have a solution for this issue: we can update the README.md file to reflect the current state of the repository and include the missing starter code.

Could you please take a look at this issue and see if it can be resolved?

Thanks in advance for your help!"

I hope this helps! Let me know if you have any other questions.

@mochi-co
Copy link
Collaborator

mochi-co commented Jan 9, 2023

Hi @BarriBarri20, can you please link to the version of the readme you are looking at? The version in master appears correct to me.

Any references to github.com/mochi-co/mqtt/v2 are for go import statements, which are handled by go mod automatically in order to correctly retrieve the latest v2.x.x version of the repo. Please review https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher

@BarriBarri20
Copy link
Author

image

Here are some of the problems Sorry, I'm not very proficient with the go language but I noticed that there are sometimes problems, could you check please?

@mochi-co
Copy link
Collaborator

mochi-co commented Jan 9, 2023

Good catch, I hadn't noticed that was missing. Fixed in latest v2.1.3 👍🏻

I also recommend checking out the examples folder and cmd/main.go for more ideas. I'll close this issue for now, but please feel free to ask any questions here and I will do my best to help you!

@BarriBarri20
Copy link
Author

Thank you I appreciate it! I also fixed the mod.go thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants