-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclusive suites,specs #524
Comments
i dont get it, what is "iit" etc? |
This is actually really useful. It's like the opposite of Yeah, grep works too, but sometimes |
oh i see, nice feature, weird implementation haha "xit" is weird too though IMO |
sounds like crap for me. 👎 |
This is a very good feature. The problem is that it's hard to name. Being able to run individual describe or it blocks by editing the code rather then using --grep is useful |
i dig it, i was sceptical about xit etc but the implementations are small which is more what matters to me. I dont want a ton of extra features if they add considerable weight, but I think we could easily translate these into --greps and reuse that logic |
for example |
@visionmedia if you implement iit we also need ddescribe and ccontext |
The better API might be
where the optional last boolean turns it into an "only run this block" |
yeah the first char thing is kinda silly, I like that it's super convenient, "xit" at least sort of reads like what it does. I dont like |
same with |
@visionmedia if you implement this either kill the context global or allow this pattern to work for all globals including test and suite and other interfaces |
yeah this pattern would have to be for the others as well. The globals don't bother me though, |
Instead of xdescribe, ddescrbe, xit, iit maybe it would be better to use symbols at the beginning of the name of test, for example # for pending and @ for exclusive:
and for exclusive tests use @ symbol at the beginneing of the name:
|
That breaks backwards compatibility |
@Raynos You mean for someone who used that symbols at the beginning for the test names? Well, I think if this method is more convenient for a workflow difficulty with backwards compatibility could be overcome. |
@whitecolor yeah I'd prefer something like that personally, it would automatically work for TDD etc too, and exports can't support this feature unless we use the titles +1 from me that's a good alternative, we can always deprecate "xit" and let that sit for a few releases |
not sure about those chars though neither of them scream exclusive or pending to me |
"!" - could be used for pending or ("?" for pending and "!" for exclusive) some symbols could be chosen as defaults but also made configurable via parameters and via mocha setup in browser. |
Guys just copy |
I definitely wouldn't call it intuitive, I had no clue what it was from looking at it, chars wouldn't be any better though. |
definitely want this lately, anyone hate |
I vote for some sort of title prefix, maybe !! |
only_ seems to be too elablorated. But why not make two options for a developer: either use "only_" or shorter variant "o" (odescribe, oit to be consistent with xdescribe, xit syntax). |
too elaborate? because it's clearer? I'm not a fan of |
|
Personally I like only_ and ignore_ because its clear, right. But I think its good to have shortcuts (like "x" and "o" prefix) either. I vote for only_ and _ignore and "o" and "x" shortcuts. |
I'm gonna lobby for |
I like I also really want a shorthand. Like |
-1 on shortcuts for me, if you're using these that often you have bigger issues IMO, it doesn't need to be that convenient . I like your suggestion @guille, less globals, a little more annoying to jump a word and type .skip but haha that goes back to the who cares thing |
iit and ddescribe is a better way to catch these keywords with lint, so while you could develop locally and ignore lint errors, the ci build tool would catch them. Is this clear? I also find it weird that xdescribe and xit was fine, but ddescribe and iit wasn't Would it be possible to reconsider this decision? |
There is the issue in Pivotal Jasmine repo that well describes the problem:
jasmine/jasmine#181 (comment)
what do you think is it worth to implement?
The text was updated successfully, but these errors were encountered: