Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node v12 failing unit test with node flag "--preserve-symlinks" #3896

Closed
juergba opened this issue Apr 30, 2019 · 0 comments · Fixed by #3900
Closed

Node v12 failing unit test with node flag "--preserve-symlinks" #3896

juergba opened this issue Apr 30, 2019 · 0 comments · Fixed by #3900
Assignees
Labels
area: node.js command-line-or-Node.js-specific type: bug a defect, confirmed by a maintainer

Comments

@juergba
Copy link
Contributor

juergba commented Apr 30, 2019

Description

Our unit tests fail with:

1) node-flags
       isNodeFlag()
         special cases
           should return true for flags starting with "preserve-symlinks":
     UnexpectedError: 
expected true to be false

It's the only failing test while running npm test on Windows.

According to Node's docu this flag should still exist. It is also included within process.allowedNodeEnvirnmentFlags.

Versions

  • The output of mocha --version and node node_modules/.bin/mocha --version: current master
  • The output of node --version: v12.1.0
  • Your operating system
    • name and version: Windows 10
    • architecture (32 or 64-bit): 64
  • Your shell (e.g., bash, zsh, PowerShell, cmd): VSCode command
  • Your browser and version (if running browser tests):
  • Any third-party Mocha-related modules (and their versions):
  • Any code transpiler (e.g., TypeScript, CoffeeScript, Babel) being used (and its version):
@juergba juergba added type: bug a defect, confirmed by a maintainer area: node.js command-line-or-Node.js-specific labels Apr 30, 2019
@juergba juergba self-assigned this Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: node.js command-line-or-Node.js-specific type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant