From 332e06970a6a67217084effbcbf68e6458ddd8c5 Mon Sep 17 00:00:00 2001 From: juergba Date: Wed, 1 May 2019 09:28:50 +0200 Subject: [PATCH] preserve-symlinks/-main flags --- test/node-unit/cli/node-flags.spec.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/test/node-unit/cli/node-flags.spec.js b/test/node-unit/cli/node-flags.spec.js index a66a17e4a2..1347f256a9 100644 --- a/test/node-unit/cli/node-flags.spec.js +++ b/test/node-unit/cli/node-flags.spec.js @@ -35,9 +35,12 @@ describe('node-flags', function() { it('should return true for flags starting with "preserve-symlinks"', function() { expect(isNodeFlag('preserve-symlinks'), 'to be true'); expect(isNodeFlag('preserve-symlinks-main'), 'to be true'); - // XXX this is not true in some newer versions of Node.js. figure out where - // this changed. - expect(isNodeFlag('preserve_symlinks'), 'to be false'); + // Node >= v12 both flags exist in process.allowedNodeEnvironmentFlags + const nodeVersion = parseInt(process.version.match(/^v(\d+)\./)[1], 10); + expect( + isNodeFlag('preserve_symlinks'), + nodeVersion >= 12 ? 'to be true' : 'to be false' + ); }); it('should return true for flags starting with "harmony-" or "harmony_"', function() {