Use Chartjs update() and rebuild chart only when necessary #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've already tested it, but ran into a legend on top not right problem with the hosts chart. I need a free slot to dive into this again. |
|
The legend alignment bug is present in your current master HEAD as well. |
|
(this was also mentioned in #93 by the original reporter and confirmed by me, before this PR was born) |
|
Hm strange, I just didn't have that before in my environment, now it is permanent. Thanks for clarifying. |
dnsmichi
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #93
Some of the arguments to
circularChartandlinearChartare now unused and should maybe also be dropped.