Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon not working on Ember 3.11 #16

Closed
ehubbell opened this issue May 26, 2020 · 9 comments
Closed

Addon not working on Ember 3.11 #16

ehubbell opened this issue May 26, 2020 · 9 comments

Comments

@ehubbell
Copy link

ehubbell commented May 26, 2020

We recently updated our application to Ember 3.11 and this addon stopped working for us. We kept getting an error message that contained chunk response something.

I then went to install filestack-js and just use the NPM module directly and, after install, the addon started working for us again. Pretty sure this addon needs to update it's dependency on filestack-js from "filestack-js": "^3.8.0" to "filestack-js": "^3.15.0" for later versions of Ember.

@miguelcobain
Copy link
Collaborator

Seems like master already has these updates. @mminkoff let us know if you need something from us to get it released.

@mminkoff
Copy link
Owner

Thanks @miguelcobain - yes, it's all done except I'm hitting this problem when running ember try: ember-cli/babel-plugin-ember-modules-api-polyfill#64, which hopefully will be resolved soon.

@ehubbell what's in master should be safe to use if you'd like. I just don't want to publish it with failing tests.

@rwjblue
Copy link

rwjblue commented May 29, 2020

ember-cli-babel@7.20.1 was just released, and should fix the underlying issue referenced in ember-cli/babel-plugin-ember-modules-api-polyfill#64.

https://github.com/babel/ember-cli-babel/releases/tag/v7.20.1

@mminkoff
Copy link
Owner

ember-filestack@3.02 was just published. It includes updating filestack.js to 3.15 and ember to 3.18. Thanks @ehubbell for reporting this, and sorry it took a few days to get it published.

@ehubbell
Copy link
Author

ehubbell commented Aug 4, 2020

@mminkoff I just updated my project to use the latest versions of ember-filestack and ember-cli-babel and I'm still running into this issue. Here are the relevant versions:

node: 11.2
ember: 3.11
ember-filestack: 3.1.1
filestack-js: 3.15
ember-cli-babel:  7.22.1

Then when I use ember-filestack as outlined in the readme I get the following error:

vendor-suffix.js:1 Uncaught (in promise) Error: Loading chunk 0 failed.
(error: http://localhost:4200/assets/chunk.b875d74302a42040ef02.js)
    at HTMLScriptElement.onScriptComplete (vendor-suffix.js:1)

Any idea what is happening here? I also tried with ember-cli-babel: 7.20.1 per @rwjblue post above to no avail.

As an edit, I don't have any trouble when I use filestack directly.

@mminkoff
Copy link
Owner

mminkoff commented Aug 4, 2020

@ehubbell Can you try updating ember-auto-import to 1.6.0? This seems to be a webpack issue, which is used by ember-auto-import.

@ehubbell
Copy link
Author

ehubbell commented Aug 4, 2020

@mminkoff Good call. That fixed the issue 😄

@mminkoff
Copy link
Owner

mminkoff commented Aug 4, 2020

Great! I’ll try to get an update out tomorrow.

@mminkoff
Copy link
Owner

mminkoff commented Aug 5, 2020

@ehubbell I just published v3.1.2 that now hopefully has everything you need. Thanks for reporting the issue and trying out upgrading ember-auto-import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants