pass: add PruneSelfMoves cleanup pass #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 76.01% 76.03% +0.02%
==========================================
Files 51 52 +1
Lines 31136 31159 +23
==========================================
+ Hits 23669 23693 +24
+ Misses 7367 7366 -1
Partials 100 100
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #76 showed that in some cases natural use of abstraction in avo programs can lead to redundant move instructions, specifically self-moves such as
MOVQ AX, AX. This does not produce incorrect code but it is incorrect and inelegant.This diff introduces a PruneSelfMoves pass that removes such unnecessary instructions.