From 6a349019da7ea79cd394101faad119db56b76bfa Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Wed, 11 Mar 2020 11:20:29 -0700 Subject: [PATCH] build: temporarily skip ASAN build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GitHub Actions doesn't have enough memory to complete an ASAN+Debug with V8 8.1. Don't take ASAN into account on CI results until we find a workaround, or until we upgrade to V8 8.2. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso Reviewed-By: Jiawen Geng Reviewed-By: Ruben Bridgewater --- .github/workflows/ASAN.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ASAN.yml b/.github/workflows/ASAN.yml index 77b8fd530adb52..3c15c134ee5c2c 100644 --- a/.github/workflows/ASAN.yml +++ b/.github/workflows/ASAN.yml @@ -9,6 +9,11 @@ jobs: steps: - uses: actions/checkout@v2 - name: Build + # TODO(mmarchini): With V8 8.1, GitHub Actions doesn't have enough + # memory to build with debug and ASAN. Allow this build to fail until + # we figure out a workaround, or until we update to 8.2 (where build + # is passing). + continue-on-error: true run: | npx envinfo ./configure --debug --enable-asan --ninja && ninja -C out/Debug