-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracking] [Docs] Model Support Streamlining #1001
Comments
Hey @CharlieFRuan I love the work you've been leading on model streamlining! One additional question I'd love to discuss with you is that we will need not only a streamlined process, but also a transparent and reproducible workflow, preferably, say, a bash script or so, to release new models on all platforms, pushing them to GitHub and weights to HuggingFace. So far, @MasterJH5574 has been in charge of new model releasing process, while knowing it's theoretically feasible, non-CMU contributors like me usually don't have sufficient incentive to push through in case of potential breaking change. Having a transparent bash script will help me personally to add new models without having to bother Ruihang all the time :) |
Hi @junrushao, thanks for bringing this up! We agree that some automation would make the process a lot less cumbersome, especially given that we have so many degrees of freedom (mode size, quantization scheme, and most importantly, platforms). I added this point to the task; we will follow up on this! cc @rickzx |
There are three aspects of releasing a model:
Likely A1 and A3 could be bundled together, but I was curious if we have a plan displaying (A1 + A3) and A2 in a table? |
The PR here #1000 displays A1 and A2 into a set of tables. In the comment, there is a pdf for easier review of the page. There are three levels from high to low:
A3 is indeed missing, and we will add it to the level 3 tables! cc @rickzx |
Thanks! Let's move the discussion to that PR |
Overview
This task focuses on streamlining the process of adding new models and keeping track of the existing prebuilt model libraries and model weights we offer. Specifically, there are three main goals:
For more on the design/layout, please see the doc here. Feel free to offer your suggestions, any insights would be greatly appreciated.
Co-author: @rickzx
Action Items
Create an end-to-end instruction/checklist on how to support a model, and where to update the documentation accordingly.(Edit: Perhaps not needed for now; include some pointers in the model prebuilt page to direct how to contribute to the tables)Draft preview in pdf; corresponding to this branch. Need to wait for the model revamp PR to merge first. Also need to add concrete examples to make the page easier to follow.Contribution log preview: so that contributors have a centralized place to record the models they compiled. We sync to the prebuilt model page once in a while (avoid and batchify cumbersome documentation updates).Edit: move the below TODOs to the future when the new compile workflow lands
Links to Related Issues and PRs
There are various past efforts to improve this aspect of MLC-LLM's workflow, e.g.:
We would hope this attempt to be more future-proof and long-lasting.
The text was updated successfully, but these errors were encountered: