Skip to content

Commit

Permalink
Fix force delete query parameter (Azure#14254)
Browse files Browse the repository at this point in the history
* remove name validation from client side

* remove name check from deploymentScripts swagger

* remove name check from previous swagger versions

* remove pattern from resourcegroupname parameter

* Fix force deletion query parameter

* add forceDeletionTypes to newer swagger
  • Loading branch information
tjegbejimba authored and mkarmark committed Jul 20, 2021
1 parent 041a9ae commit e491b24
Show file tree
Hide file tree
Showing 9 changed files with 98 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"parameters": {
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"resourceGroupName": "my-resource-group",
"forceDeletionResourceTypes": "Microsoft.Compute/virtualMachines,Microsoft.Compute/virtualMachineScaleSets",
"forceDeletionTypes": "Microsoft.Compute/virtualMachines,Microsoft.Compute/virtualMachineScaleSets",
"api-version": "2020-06-01"
},
"responses": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"parameters": {
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"resourceGroupName": "my-resource-group",
"forceDeletionResourceTypes": "Microsoft.Compute/virtualMachines",
"forceDeletionTypes": "Microsoft.Compute/virtualMachines",
"api-version": "2020-06-01"
},
"responses": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2479,11 +2479,11 @@
"maxLength": 90
},
{
"name": "forceDeletionResourceTypes",
"name": "forceDeletionTypes",
"in": "query",
"required": false,
"type": "string",
"description": "The resource types you want to force delete. Currently, only the following is supported: forceDeletionResourceTypes=Microsoft.Compute/virtualMachines,Microsoft.Compute/virtualMachineScaleSets"
"description": "The resource types you want to force delete. Currently, only the following is supported: forceDeletionTypes=Microsoft.Compute/virtualMachines,Microsoft.Compute/virtualMachineScaleSets"
},
{
"$ref": "#/parameters/ApiVersionParameter"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"parameters": {
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"resourceGroupName": "my-resource-group",
"forceDeletionTypes": "Microsoft.Compute/virtualMachines,Microsoft.Compute/virtualMachineScaleSets",
"api-version": "2020-06-01"
},
"responses": {
"202": {
"description": "Accepted"
},
"200": {
"description": "OK"
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"parameters": {
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"resourceGroupName": "my-resource-group",
"forceDeletionTypes": "Microsoft.Compute/virtualMachines",
"api-version": "2020-06-01"
},
"responses": {
"202": {
"description": "Accepted"
},
"200": {
"description": "OK"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2554,13 +2554,28 @@
"minLength": 1,
"maxLength": 90
},
{
"name": "forceDeletionTypes",
"in": "query",
"required": false,
"type": "string",
"description": "The resource types you want to force delete. Currently, only the following is supported: forceDeletionTypes=Microsoft.Compute/virtualMachines,Microsoft.Compute/virtualMachineScaleSets"
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
}
],
"x-ms-examples": {
"Force delete all the Virtual Machines in a resource group": {
"$ref": "./examples/ForceDeleteVMsInResourceGroup.json"
},
"Force delete all the Virtual Machines and Virtual Machine Scale Sets in a resource group": {
"$ref": "./examples/ForceDeleteVMsAndVMSSInResourceGroup.json"
}
},
"responses": {
"200": {
"description": "OK"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"parameters": {
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"resourceGroupName": "my-resource-group",
"forceDeletionTypes": "Microsoft.Compute/virtualMachines,Microsoft.Compute/virtualMachineScaleSets",
"api-version": "2020-06-01"
},
"responses": {
"202": {
"description": "Accepted"
},
"200": {
"description": "OK"
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"parameters": {
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"resourceGroupName": "my-resource-group",
"forceDeletionTypes": "Microsoft.Compute/virtualMachines",
"api-version": "2020-06-01"
},
"responses": {
"202": {
"description": "Accepted"
},
"200": {
"description": "OK"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2606,13 +2606,28 @@
"minLength": 1,
"maxLength": 90
},
{
"name": "forceDeletionTypes",
"in": "query",
"required": false,
"type": "string",
"description": "The resource types you want to force delete. Currently, only the following is supported: forceDeletionTypes=Microsoft.Compute/virtualMachines,Microsoft.Compute/virtualMachineScaleSets"
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
}
],
"x-ms-examples": {
"Force delete all the Virtual Machines in a resource group": {
"$ref": "./examples/ForceDeleteVMsInResourceGroup.json"
},
"Force delete all the Virtual Machines and Virtual Machine Scale Sets in a resource group": {
"$ref": "./examples/ForceDeleteVMsAndVMSSInResourceGroup.json"
}
},
"responses": {
"200": {
"description": "OK"
Expand Down

0 comments on commit e491b24

Please sign in to comment.