Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBY incompletely shuts down using Exit command as shell #263

Open
DJOMaverick opened this issue Jan 23, 2025 · 1 comment
Open

PBY incompletely shuts down using Exit command as shell #263

DJOMaverick opened this issue Jan 23, 2025 · 1 comment

Comments

@DJOMaverick
Copy link

Describe the bug
When running PBY as a shell, pressing Exit PinballY in the exit menu does not completely shut the program down. It visibly appears to close (including disappearing from the task ar), and will run the exit command (such as Explorer), but DOF lights will not terminate. Opening Task Manager shows PinballY to still be running.

To Reproduce

  1. Set exit command as Explorer.exe
  2. Use InstantSheller to set PinballY as the shell (or manually change registry key HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Winlogon\Shell )
  3. Reboot PC so it launches PBY
  4. Open exit menu and press Exit PinballY

Expected behavior
PinballY completely closes and terminates DOF, and starts Explorer.

Windows version
Windows 10 Enterprise

@mjrgh
Copy link
Owner

mjrgh commented Jan 24, 2025

I'd say this isn't a bug, it's just an unsupported configuration. PinballY is a Windows desktop application, not a Windows shell, and evidently there's something different/extra that a program has to do to be a Windows shell. If anything, I'm surprised it works at all, and that this is the only problem you've noticed (assuming it's the only problem you've noticed). So perhaps you could refile this as an enhancement request, "Support running as a Windows shell", or better yet, figure out what the required changes and/or extensions are and file a pull request implementing them. Alternatively, there are a couple of ways mentioned in the documentation to launch at startup that don't involve trying to make PinballY run as a shell, if you can use one of those instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants