Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots flipped upside-down when using ddagrab in 1.1 Beta 10 #252

Open
jueank opened this issue Nov 22, 2024 · 4 comments
Open

Screenshots flipped upside-down when using ddagrab in 1.1 Beta 10 #252

jueank opened this issue Nov 22, 2024 · 4 comments

Comments

@jueank
Copy link

jueank commented Nov 22, 2024

I just tested ddagrab in version 1.1 Beta 10, using the suggested image codec options: -frames:v 1 -update 1
I use exclusive fullscreen mode for VPX. Fullscreen optimisations are disabled (see here: https://devblogs.microsoft.com/directx/demystifying-full-screen-optimizations/)

The captured playfield was flipped upside down. Is this to be expected because you let users control the ffmpeg options for ddagrab completely on their own (meaning they have to add a video transform parameter), or should this treated as a bug?

@mjrgh
Copy link
Owner

mjrgh commented Nov 22, 2024

Did you include the [videoTransforms] in the source options per the help?

http://mjrnet.org/pinscape/downloads/PinballY/Help/CaptureFfmpegOptions.html#ddagrab-how-to

@jueank
Copy link
Author

jueank commented Nov 22, 2024

It's working now as intended with the entries from the help in 'Video Source Options'. Now that you mention it, it's obvious, but to be honest - I thought 'video source options' are really only relevant for video encoding, not for single images. But technically, it makes sense and I should have known if I had thought about it for 3 seconds longer...
You could change the name to 'Video & Image Source Options' if you want to?

@mjrgh
Copy link
Owner

mjrgh commented Nov 22, 2024

You could change the name to 'Video & Image Source Options' if you want to?

Good idea - I agree it's a little misleading that it only mentions video.

@jueank
Copy link
Author

jueank commented Nov 23, 2024

I would like to say thank you for including the ddagrab option! I have used it quite a lot in the last 2 days already. It works very reliably! Much better than gdigrab where I had to ALT-TAB out and ALT-TAB back into VPX to update the gdi framebuffer. It really is a time saving improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants