-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does this need updating with current MJML version? #42
Comments
I realized after I posted this that I'm really conflating a (possible) bug report with a support request. So let me make them clearer: Should the boilerplate as it currently exists work with the current version (4.10.0) of MJML? If so, can I request a pointer on what I'm doing wrong in terms of actually using a custom component? If the answer is "don't use |
Can you check what |
Hmm, using |
OK, I was able to isolate it, and it does work -- so it must be some bug in my build that I'll work out. In the process, I created an example repo that more explicitly explains how to use a custom component once it's created, and uses updated Gulp syntax. So for anyone else who stumbles across this and is dense like me, maybe that example will help :) If you think any of the documentation from my example would be helpful here, let me know and I'll create a PR. Otherwise you can close. |
First I confess that even after reading the documentation and the tutorial, I'm not 100% sure how I'm supposed to load the custom components in a project, once I've built them.
I take it from what's written that I use the built version from
/lib
of, say,MjBasicComponent.js
and include it this way:(I realize I'm using
gulp-mjml
and a more modern version of Gulp syntax than what the tutorial uses, and not using Babel, so maybe that's the source of some of my issues.) But when I do that I get either:if I haven't used the
<mj-basic-component>
tag, or:if I have.
So then I thought maybe it was an issue with the current version of MJML (4.10.0) being newer than what's specified in the boilerplate (4.7.1). But if I try to bump up the version in
package.lock
, and thenyarn install
,yarn build
fails with:so I'm guessing some of the other packages need to be updated too.
The text was updated successfully, but these errors were encountered: