Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let User change the PathfindingCommand skip distance #1047

Open
bullzombie43 opened this issue Feb 1, 2025 · 0 comments
Open

Let User change the PathfindingCommand skip distance #1047

bullzombie43 opened this issue Feb 1, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@bullzombie43
Copy link

Is your feature request related to a problem? Please describe.
We kept running into an issue when pathfinding to the reef that if we switched from targetting the left branch to the right, it would still go to the old branch position. We tracked the issue down to in PathfindingCommand it doesn't update the trajectory, if you're within 2m of the target position. This makes sense to prevent unnecessary switches as your finishing the path but led to issues as it wouldn't update the path despite that it should be targeting an entirely new pose.

Describe the solution you'd like

One simple solution would be to change the number 2.0m to a static variable skipChangeDistance, retaining the default value as 2.0m. Then providing users a static method to change this variable.

Image

Additional context
Add any other context or screenshots about the feature request here.

I'd be happy to make this change myself, though I might need some help to build manually.

@bullzombie43 bullzombie43 added the enhancement New feature or request label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant