Waveform Hotcue Markers are shifted to the right

[mixxxbot]

Reported by: Holzhaus
Date: 2020-04-05T15:55:08Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1870942
Attachments: [Cue Markers Offset GIF](https://bugs.launchpad.net/bugs/1870942/+attachment/5347150/+files/Cue Markers Offset GIF), [Screenshot from 2020-04-10 18-48-46.png](https://bugs.launchpad.net/bugs/1870942/+attachment/5351646/+files/Screenshot from 2020-04-10 18-48-46.png)

---

The hotcue markers on the scrolling waveforms are slightly shifted to the right. I assume this is related to the drawing of the markers (so the cues are not actually shifted), because the shift offset stays the same when zooming in/out.

I attached a GIF that shows the problem.

[mixxxbot]

Commented by: Holzhaus
Date: 2020-04-05T15:55:08Z
Attachments: [Cue Markers Offset GIF](https://bugs.launchpad.net/mixxx/+bug/1870942/+attachment/5347150/+files/Cue Markers Offset GIF)

[mixxxbot]

Commented by: Holzhaus
Date: 2020-04-05T16:10:55Z

---

The same happens with the main cue marker. The intro/outro markers are not affected.

[mixxxbot]

Commented by: Be-ing
Date: 2020-04-10T20:34:39Z

---

I checked 2.2 and could not replicate this, so this is a regression introduced in master.

[mixxxbot]

Commented by: Be-ing
Date: 2020-04-10T21:31:53Z

---

My first guess was that #2238 was when the regression was introduced, but I tested the last commit of that branch (05d4464) and could not reproduce this bug.

[mixxxbot]

Commented by: Be-ing
Date: 2020-04-10T23:20:58Z

---

Git bisect identified f024e75 as the first bad commit.

[mixxxbot]

Commented by: Be-ing
Date: 2020-04-10T23:49:27Z
Attachments: [Screenshot from 2020-04-10 18-48-46.png](https://bugs.launchpad.net/mixxx/+bug/1870942/+attachment/5351646/+files/Screenshot from 2020-04-10 18-48-46.png)

---

Only cues without labels are affected

[mixxxbot]

Commented by: Be-ing
Date: 2020-04-11T00:09:35Z

---

Fix is here: #2648

[mixxxbot]

Issue closed with status Fix Released.