Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access \ edit track properties from Computer library entry #9897

Open
mixxxbot opened this issue Aug 23, 2022 · 3 comments
Open

access \ edit track properties from Computer library entry #9897

mixxxbot opened this issue Aug 23, 2022 · 3 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: mevsme
Date: 2020-03-09T21:15:30Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp1866707


I tend to use folders of "Computer" than playlists or library to pick up songs. So to be able to edit artist or comment or title, I need to use playlists or 3rd party software. Can mixxx offer some basic id3 tag editing available from built in file browser?

@mixxxbot
Copy link
Collaborator Author

mixxxbot commented Aug 23, 2022

Commented by: ronso0
Date: 2020-03-10T12:09:09Z


Unless you're looking for a mass-editing tool, we already provide that functionality.
I just tried the following in master:

  • go to Preferences > Library
    -> check "Export: write modified file metadata from the library into file tags

There'll be a popup saying:

Mixxx may wait to modify files until they are not loaded to any decks or samplers.
If you do not see changed metadata in other programs immediately,
eject the track from all decks and samplers or shutdown Mixxx."

  • in Mixxx, open a folder in Computer, pick a track
  • edit metadata, press Enter
  • right-click that track > Open In File Browser
    -> double-check the metadata has been exported

If you want to try a master (alpha) build, head over to
http://downloads.mixxx.org/builds/master/release/
and pick a built for your OS.
! Remember to back up your config and database before you install an alpha build. Info on that is there https://www.mixxx.org/wiki/doku.php/testing

@mixxxbot
Copy link
Collaborator Author

mixxxbot commented Aug 23, 2022

Commented by: mevsme
Date: 2020-03-14T17:03:17Z


Can I have 'properties' right click menu entry in file browser part of library?

The thing is that it is impossible to find a track\audio file without ID3 tags in library, but you can easily find them in file browser, but there is no way you can edit them easily to fill up the missing id3 tags\propeties.

@ronso0
Copy link
Member

ronso0 commented Aug 6, 2024

Just stumbled over this again, here's some update / clarification (using Mixxx 2.5, not verified with earlier versions).

Track Properties is for editing the metadata of tracks in the library.
The underlying issue here is that "Computer" (and Recordings) is kind of a file browser, i.e. it shows track files that may or may not be in the Mixxx library and reads the file tags. (sorry I didn't notice/consider this fact earlier)

When editing a track in Computer that is not yet in the Mixxx library like this (or Recordings, add a track file to the Recordings directory, for simplicity)

  • select track file
  • click a metadata field (inline editor opens)
  • edit, apply

the track file is imported into the Mixxx library (here) and the edited metadata is saved (in the library).
--> This can be verified by going to Tracks, find that track, check edited metadata.

However, Computer is still just a file parser (id3/other tags), so when going to Recordings again, Mixxx still doesn't care whether that track is in the library or not, so it'll again read the file tags, and the edited values won't be visible, yet, unless the metadata has been exported to file tags explicitly. (export tags to track files as described above).

Would be cool if BrowseThread / BrowseTableModel would recognize library tracks and use that metadata instead of file tags.
(the fix is actually just a few lines in BrowseThread, but is not applicable due to thread affinity assertions in TrackCollection / ~Manager)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants