Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard shortcut not shown for skin preferences #9796

Closed
mixxxbot opened this issue Aug 23, 2022 · 10 comments
Closed

keyboard shortcut not shown for skin preferences #9796

mixxxbot opened this issue Aug 23, 2022 · 10 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: foss-4
Date: 2019-11-10T13:53:19Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1851993
Attachments: [missing keyboard shortcut.png](https://bugs.launchpad.net/bugs/1851993/+attachment/5304217/+files/missing keyboard shortcut.png), Screenshot.jpg, Screenshot_1.jpg, Screenshot_2.jpg


This is a follow up bug report to https://bugs.launchpad.net/mixxx/+bug/1826724 (macOS keyboard shortcuts for fullscreen and skin preferences not shown / working).

Fullscreen keyboard shortcut is now shown and working as expected.
Verified on macOS 10.14.6 + mixxx 2.3.0-alpha-pre (build master r6987)

Issue with skin preferences is persisting though: the menubar View > Skin Preferences entry still shows a questionmark icon instead of keyboard shortcut.

locale set to system (which is german).

@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-11-10T13:53:19Z
Attachments: [missing keyboard shortcut.png](https://bugs.launchpad.net/mixxx/+bug/1851993/+attachment/5304217/+files/missing keyboard shortcut.png)

@mixxxbot
Copy link
Collaborator Author

Commented by: geozubuntu
Date: 2019-11-16T15:45:38Z


Also in Windows 7 with locale Greek. This is shown "View?" (without "" of course). Thanks

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-11-17T22:51:21Z


I can not confirm that. However, I have an issue that I have two Greek translations.
Can you do a screenshot?

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-11-26T17:24:00Z


fix confirmed, this is great as this problem has been going on for a long time. thanks to all involved with fixing this minor detail.

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-11-26T17:24:19Z


fix is here: #2358

@mixxxbot
Copy link
Collaborator Author

Commented by: geozubuntu
Date: 2019-11-26T18:41:16Z
Attachments: Screenshot.jpg


@ Daniel Schürmann (daschuer) Sorry for late answer, I was on a trip with limited Net access.

Yes there are two options for Greek translations in options.
The second one is better. The first is not complete and not so good IMHO. My suggestion.. Keep the first and discard the second one.

Please see the following 3 screenshots with comments.

@mixxxbot
Copy link
Collaborator Author

Commented by: geozubuntu
Date: 2019-11-26T18:42:33Z
Attachments: Screenshot_1.jpg


Not so good, partial Greek Translation.

@mixxxbot
Copy link
Collaborator Author

Commented by: geozubuntu
Date: 2019-11-26T18:43:32Z
Attachments: Screenshot_2.jpg


The better, more complete Greek Translation.

@mixxxbot
Copy link
Collaborator Author

Commented by: geozubuntu
Date: 2019-11-30T20:54:01Z


Win 7 locale Greek 2.3.0-alpha-pre (build master r7016) problem exists. Check above post #⁠6, and screenshots #⁠7, #⁠8.

Thanks.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.2.3 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant