Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep selected track in view when chananging search filter #9377

Closed
mixxxbot opened this issue Aug 23, 2022 · 6 comments
Closed

Keep selected track in view when chananging search filter #9377

mixxxbot opened this issue Aug 23, 2022 · 6 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2018-07-07T08:17:45Z
Status: Fix Committed
Importance: Wishlist
Launchpad Issue: lp1780528


Sometimes I want to see neighbour tracks, in the library according to the current sort.
For example, I know a track that was added at a date. I cant remember the title, but I can remember the title of the track I have added at the same time.

Now I search for the neighbour, and reduce the filter to see the resulting tracks.
Currently the found track moves out of sight and looses selection. That should not happen.

I have the feeling that this bug was fixed in some version ... unsure though.
currently 2.1 and master is effected.

@mixxxbot
Copy link
Collaborator Author

Commented by: beenisss
Date: 2019-02-24T20:23:35Z


I'd be interested in picking this up. I'd also like the selected track to stay in view if I change the sort order, which it currently doesn't.

When you say this may have been fixed or looked at before - any idea how I might find the relevant PR or bug ticket? As that may help with fixing it.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-02-24T22:25:46Z


What happens when the new search doesn't contain the previously selected track?

I'd say it should be remembered for when the previous search is restored, or when the track appears in any next search (for example after correcting a typo).
When the users changes the selection that track pointer should be cleared.

@mixxxbot
Copy link
Collaborator Author

Commented by: beenisss
Date: 2019-02-25T19:17:34Z


@daschuer maybe you are thinking of a couple of bugs where this was raised before:

https://bugs.launchpad.net/mixxx/+bug/1462073
https://bugs.launchpad.net/mixxx/+bug/1462074

@mixxxbot
Copy link
Collaborator Author

Commented by: beenisss
Date: 2019-02-25T19:21:16Z


Actually that's not strictly the same, however it may be that one issue causes the other. Maybe if tracks don't become unselected, they will stay in view.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2022-06-27T10:14:57Z


#4177
and
#4536

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant