Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't Open Apple Lossless m4a files #7526

Closed
mixxxbot opened this issue Aug 22, 2022 · 15 comments
Closed

Won't Open Apple Lossless m4a files #7526

mixxxbot opened this issue Aug 22, 2022 · 15 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: davidbirch1
Date: 2014-07-02T22:26:54Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1336982


I can open m4a files encoded in lossy AAC. However, when I try to open lossless m4a files encoded in ALAC, a message saying the track could not be loaded is displayed.

@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2015-11-23T13:40:15Z


The SoundSourceM4A plugin uses FAAD2 to decode .m4a files. Currently Mixxx determines the file type solely by the file extension. Unfortunately ALAC files use the same file extension "m4a". Only a single SoundSource as registered for each file extension.

As a workaround we could use the approach I proposed here to register multiple SoundSources for the same file extension:

#605

Drawback: SoundSourceM4A will fail to open an ALAC file and log a warning message. Only then the to-be-created SoundSourceALAC decoder will take over (assuming that is has been assigned a lower priority than SoundSourceM4A).

We should also rename SoundSourceM4A to SoundSourceFAAD2.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2015-11-23T13:43:53Z


If libsndfile is now able to decode ALAC files we could register SoundSourceSndFile with a lower priority for the file extension "m4a" and there is no need for a new specialized SoundSource.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2016-01-24T02:13:19Z


#605 is now merged. Is this bug solved?

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2016-03-12T19:38:58Z


#904

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2016-05-07T09:16:01Z


ALAC files with the extension .m4a should play now when building Mixxx with libsndfile 1.0.26.

I'm not able to check this myself, because Fedora 23 still comes with libsndfile 1.0.25.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2016-05-26T17:32:01Z


Unfortunately libsndfile 1.0.26 only reads ALAC/CAF, but not ALAC/M4A files.

Disabled support for M4A files in SoundSourceSndFile:
#955

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2017-01-26T19:19:19Z


I just got confirmation from Erik (main libsndfile developer) that the lack of ALAC/M4A support is simply due to manpower, so one of us could add it to libsndfile. https://github.com/erikd/libsndfile/

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2017-01-26T19:25:48Z


He also said to add a new container (or codec) just copy one of the existing ones (like src/au.c) and make the appropriate changes.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2017-09-28T20:44:26Z


#1356

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2019-05-08T21:32:57Z


Requires FFmpeg 4.x:
#1356

@mixxxbot
Copy link
Collaborator Author

Commented by: stan3
Date: 2020-04-24T20:20:05Z


Apple Lossless (ALAC files with .m4a extension) still don't play on Mixxx 2.3.0 latest nightly alpha as of 2020-04-24. Was the correct fix committed?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-04-24T20:54:57Z


Ok, so we need to reopen this. Please post the last line from the mixxx.log after you have tried to load a ALAC file.
https://www.mixxx.org/wiki/doku.php/finding_the_mixxx.log_file

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2020-04-24T21:19:50Z


We are even performing tests on an ALAC file included in the repo.

Please remember to build Mixxx with FFmpeg enabled, otherwise it won't work. Ubuntu 18.04 uses and outdated FFmpeg version that is not supported.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2020-04-24T22:03:45Z


Tested. Works.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant