New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Star rating in track properties clears other unsaved properties #11540

Closed

RadioDM opened this issue May 6, 2023 · 3 comments · Fixed by #11565

Labels

Milestone

RadioDM commented May 6, 2023

Bug Description

Clicking on any of 5 stars in file/track properties inside Mixxx, will revert unsaved changes in all other fields.
I think this bug lasted for long, but never reported it since.

To reproduce:
In library right mouse click on any track > properties > type anything in any input field/s > click on star class. (doesn't matter the initial star value) > unsaved changes reverted.

Let me know if backtrace log is needed

Version

2.4-alpha-1467-g425ad1e47a

OS

Windows 10 Pro 21H2

RadioDM added the bug label

ronso0 added the confirmed label

ronso0 added this to the 2.4.0 milestone

Member

ronso0 commented May 6, 2023

Working on it, since I added the star rating there.

The challenge is not fixing the issue but keeping both DlgTrackInfo and WStarRating clean...

ronso0 mentioned this issue

WStarRating: don't update track directly, use signals/slots #11565

Merged

ronso0 linked a pull request

that will close this issue

WStarRating: don't update track directly, use signals/slots #11565

Merged

ronso0 changed the title ~~Updating Star classification in file properties clears other unsaved properties~~ Updating Star rating in track properties clears other unsaved properties

Member

daschuer commented Jun 8, 2023

This issue also happens in 2.3.5

Member

ronso0 commented Jun 8, 2023 •

edited

Loading

Oh. In that case I'll try to rebase #11565
(thought we added that in 2.4)

daschuer closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment