Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller script error due to ShowDurationRemaining Mixxx control #10967

Open
JosepMaJAZ opened this issue Oct 15, 2022 · 6 comments
Open

controller script error due to ShowDurationRemaining Mixxx control #10967

JosepMaJAZ opened this issue Oct 15, 2022 · 6 comments
Labels

Comments

@JosepMaJAZ
Copy link
Contributor

Bug Description

On Mixxx main, there is a problem at least with the Mixxx control ShowDurationRemaining as it is used in the Mapping for Numark Mixtrack Platinum.
https://manual.mixxx.org/2.3/en/mixxx-control.html#cap-[Controls]

The init of the mapping makes a connection to that control
// setup elapsed/remaining tracking
engine.makeConnection("[Controls]", "ShowDurationRemaining", MixtrackPlatinum.timeElapsedCallback);

If Mixxx is already started, the mapping can be used without issues.
If you restart Mixxx, you get the following error:
image

This control Object is currently created on the DlgPrefDeck constructor (Same for TimeFormat), so when the controller is initialized, the control hasn't yet been created. I am unsure where it should be created instead.

Version

2.4.0 alpha

OS

Windows 10

@JosepMaJAZ JosepMaJAZ added the bug label Oct 15, 2022
@ronso0
Copy link
Member

ronso0 commented Oct 15, 2022

No better place comes to mind.. we can't just create all COs possibly used in mappings in coreservices (or whereever).

Anyhow, should be fixed by #4651, no?

@ywwg
Copy link
Member

ywwg commented Oct 23, 2022

I am also surprised this is not fixed by that change, strange.

@ywwg
Copy link
Member

ywwg commented Oct 23, 2022

well er #4661 is the final version of that PR

@ywwg
Copy link
Member

ywwg commented Oct 23, 2022

ah ok we went with a different approach that only created a specific set of menubar control objects. ShowDurationRemaining will have to be manually added to the list for it to show up properly

@JosepMaJAZ
Copy link
Contributor Author

Copying here from zulip:
I believe the problem in this case is that the controls are created on the dialog itself, not on the settings. And we are talking about official, documented controls.
As such, these two need to be moved. Is the settings load/default a good candidate?

@ronso0
Copy link
Member

ronso0 commented Oct 23, 2022

Let's simply merge #4651 and this and similar issues are solved.
All that's missing is a manual test with Qt6/QML. How can do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants