-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controller script error due to ShowDurationRemaining Mixxx control #10967
Comments
No better place comes to mind.. we can't just create all COs possibly used in mappings in coreservices (or whereever). Anyhow, should be fixed by #4651, no? |
I am also surprised this is not fixed by that change, strange. |
well er #4661 is the final version of that PR |
ah ok we went with a different approach that only created a specific set of menubar control objects. ShowDurationRemaining will have to be manually added to the list for it to show up properly |
Copying here from zulip: |
Let's simply merge #4651 and this and similar issues are solved. |
Bug Description
On Mixxx main, there is a problem at least with the Mixxx control ShowDurationRemaining as it is used in the Mapping for Numark Mixtrack Platinum.
https://manual.mixxx.org/2.3/en/mixxx-control.html#cap-[Controls]
The init of the mapping makes a connection to that control
// setup elapsed/remaining tracking
engine.makeConnection("[Controls]", "ShowDurationRemaining", MixtrackPlatinum.timeElapsedCallback);
If Mixxx is already started, the mapping can be used without issues.
If you restart Mixxx, you get the following error:
This control Object is currently created on the DlgPrefDeck constructor (Same for TimeFormat), so when the controller is initialized, the control hasn't yet been created. I am unsure where it should be created instead.
Version
2.4.0 alpha
OS
Windows 10
The text was updated successfully, but these errors were encountered: