mixxx control for Big Library

[mixxxbot]

Reported by: mikelpr
Date: 2021-08-25T04:01:51Z
Status: Confirmed
Importance: Medium
Launchpad Issue: lp1941027

---

a control is needed to assign Big Library to controllers. something like [Library],ShowBigLibrary and [Library],HideBigLibrary / [Library],ToggleBigLibrary

[mixxxbot]

Commented by: Be-ing
Date: 2021-08-25T04:12:26Z

---

This already exists: [Master], maximize_library

[mixxxbot]

Commented by: ronso0
Date: 2021-08-26T22:04:35Z

---

@mikel Pérez
how did you try to map your controller?

In the MIDI Wizard you'll find the control in the 'User Interface' submenu

I think we should create an alias '[Library],maximize' so that it can be found in the 'Library' controls group in the manual, too.

[mixxxbot]

Commented by: Be-ing
Date: 2021-08-27T02:09:21Z

---

I like the idea of aliasing [Master], maximize_library to [Library], maximize.

[mixxxbot]

Commented by: Holzhaus
Date: 2021-08-27T07:35:20Z

---

This is not an "official" control. It's created by skins any may simply not exist if you select another skin.

If we want to make it "official", we should always create it and let skins connect to it instead of owning it.

[mixxxbot]

Commented by: ronso0
Date: 2021-08-29T23:07:59Z

---

(setting to 'Incomplete' so it can be found in the default bug listing)

Though this control is used in all official skins,and it's listed in the control picker menu of the MIDI Wizard. The respective action in the menu bar is inactive (greyed out) if the skin doesn't use/supply the control.

Would mappings fail if it hasn't been created, or just complain?

[mixxxbot]

Commented by: mikelpr
Date: 2021-09-03T02:20:50Z

---

@ronso0 would be nice, that's where I looked for it. never would have thought it was under Master

[mixxxbot]

Commented by: ronso0
Date: 2021-10-04T19:49:48Z

---

I guess the appropriate place to create [Library],maximize is in coreservices, no? Like [Controls],touch_shift

mixxx/src/coreservices.cpp

Line 440 in 867a4b9

m_pTouchShift = std::make_unique<ControlPushButton>(ConfigKey("[Controls]", "touch_shift"));

[mixxxbot]

Commented by: ronso0
Date: 2021-10-04T21:09:04Z

---

#4355

[mixxxbot]

Commented by: ronso0
Date: 2021-10-05T17:56:20Z

---

Let's sort the controls by category to increase discoverabilty
mixxxdj/manual#441

[daschuer]

Fixed in #4647