From 3a283b0ff4ba695031800104a497983a60fe910f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Sch=C3=BCrmann?= Date: Tue, 19 Oct 2021 23:45:40 +0200 Subject: [PATCH] Added a TODO for another probably data race in effectprocessor. --- src/effects/backends/effectprocessor.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/effects/backends/effectprocessor.h b/src/effects/backends/effectprocessor.h index 02fddd1c6cb..c5884f1f61a 100644 --- a/src/effects/backends/effectprocessor.h +++ b/src/effects/backends/effectprocessor.h @@ -273,6 +273,11 @@ class EffectProcessorImpl : public EffectProcessor { // m_channelStateMatrix may be accessed concurrently in the audio // engine thread in loadStatesForInputChannel. + // TODO: How is ensure that the statMap is not accessed during this loop? + // This is called in responds to DISABLE_EFFECT_CHAIN_FOR_INPUT_CHANNEL + // and it looks like that the objects pointed by m_channelStateMatrix + // may be still in use. + // Probably related: https://bugs.launchpad.net/mixxx/+bug/1775497 ChannelHandleMap& stateMap = m_channelStateMatrix[*inputChannel]; for (EffectSpecificState* pState : stateMap) {