diff --git a/configure b/configure index b4936f148a2b9c..f42d82d3f1ddda 100755 --- a/configure +++ b/configure @@ -485,8 +485,8 @@ def check_compiler(o): ok, is_clang, clang_version, gcc_version = try_check_compiler(CXX, 'c++') if not ok: warn('failed to autodetect C++ compiler version (CXX=%s)' % CXX) - elif clang_version < '3.4.0' if is_clang else gcc_version < '4.8.0': - warn('C++ compiler too old, need g++ 4.8 or clang++ 3.4 (CXX=%s)' % CXX) + elif clang_version < '3.4.0' if is_clang else gcc_version < '4.7.0': + warn('C++ compiler too old, need g++ 4.7 or clang++ 3.4 (CXX=%s)' % CXX) ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c') if not ok: diff --git a/src/stream_base.cc b/src/stream_base.cc index 27ae0fee7b1309..51377c2bad5487 100644 --- a/src/stream_base.cc +++ b/src/stream_base.cc @@ -443,6 +443,7 @@ Local StreamBase::GetObject() { return GetAsyncWrap()->object(); } +StreamBase::~StreamBase() = default; int StreamResource::DoTryWrite(uv_buf_t** bufs, size_t* count) { // No TryWrite by default @@ -459,4 +460,6 @@ void StreamResource::ClearError() { // No-op } +StreamResource::~StreamResource() = default; + } // namespace node diff --git a/src/stream_base.h b/src/stream_base.h index d0e1d4b9b253d5..882bd5c99fbe2c 100644 --- a/src/stream_base.h +++ b/src/stream_base.h @@ -131,7 +131,7 @@ class StreamResource { StreamResource() { } - virtual ~StreamResource() = default; + virtual ~StreamResource(); virtual int DoShutdown(ShutdownWrap* req_wrap) = 0; virtual int DoTryWrite(uv_buf_t** bufs, size_t* count); @@ -215,7 +215,7 @@ class StreamBase : public StreamResource { explicit StreamBase(Environment* env) : env_(env), consumed_(false) { } - virtual ~StreamBase() = default; + virtual ~StreamBase(); // One of these must be implemented virtual AsyncWrap* GetAsyncWrap();