Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n support #20

Closed
ai opened this issue Oct 26, 2016 · 3 comments
Closed

I18n support #20

ai opened this issue Oct 26, 2016 · 3 comments

Comments

@ai
Copy link

ai commented Oct 26, 2016

Thanks for picker, it is awesome!

We are integrating to Russian website and want to translate categories and other texts (like Search placeholder). I didn’t find a way to do it.

Is is possible or we need to extend API?

@EtienneLem
Copy link
Member

Good call. Just took a look at the codebase and it really is just the categories and the search input that have static text, will be pretty easy to implement without the use of a third party library. Right now, I don’t think there would be a way to do that other than doing some JS shenanigans after mounting the component.

No promises, but I should be able to find time in the next ~24 hours and release a new version that includes I18n support.

@ai
Copy link
Author

ai commented Oct 26, 2016

Yeap, I think we could just add some props like i18n or texts:

<Picker texts={{ search: 'Поиск', smiles: 'Смайлы', food: 'Еда' }}>

@EtienneLem
Copy link
Member

Added i18n prop to Picker (v0.3.1). See README#i18n for the object signature.

Thanks for the suggestion, let me know if it doesn’t work as expected 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants