Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Command to create comments on pull requests #1203

Closed
nchen-lv opened this issue Jun 29, 2016 · 5 comments
Closed

[Feature Request] Command to create comments on pull requests #1203

nchen-lv opened this issue Jun 29, 2016 · 5 comments
Labels

Comments

@nchen-lv
Copy link

nchen-lv commented Jun 29, 2016

Not sure if this is possible, but it would be helpful to be able to add/create new comments to existing pull requests. This would work hand in hand w/ Jenkins pull request builder plugin which uses PR comments as trigger phrases for merge/build.

@mislav mislav added the feature label Jul 12, 2016
@mislav
Copy link
Owner

mislav commented Sep 13, 2016

This is not on our roadmap yet, but shouldn't be hard to implement once we finally get to it. I was thinking of implementing a low-level api command that would help you make manual API requests to perform operations not supported by hub. Such a command could make scripting to create a pull request comment very easy.

@stensson
Copy link

stensson commented Feb 1, 2017

@mislav : Just checking here, are there still no plans to add this feature?

I would love to have a command like

hub comment <issue-no/PR-no> -m "comment content"

for a few use cases.

I primarily want this in order to add a reminder comment with a task list at the bottom of a PR with a lot of commits. For example to remind the user to review the code and docs before merging a huge release branch with the past 4 weeks of commits into master. If this reminder is only in the PR description at the top, it is likely to be missed.

Another use for it could be for an automated build/test system to add some details about the build into a comment on the PR.

If I remember the Github v3 API correctly, issues and PRs are the "same thing", which means this command could be used to comment both issues and PRs alike.

@mislav
Copy link
Owner

mislav commented Sep 4, 2018

There is a PR open to add a hub comment command #1465

I still haven't had time to properly review it and reach a decision about whether I like its API or do I imagine it to be different.

@sebszocinski
Copy link

+1 on this, I installed this planning to do just this and was bummed when I found out it's not a feature

@mislav
Copy link
Owner

mislav commented Jan 26, 2019

After some consideration, I have decided that—for now—this is best implemented in user scripts, rather than maintained in hub core. Now that there is a new hub api command, I will close this feature request and leave implementing this as an exercise to the reader. https://github.com/github/hub/releases/tag/v2.8.3 #2016

For example, see the resolution in #623 (comment)

Thank you for suggesting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants