Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble running pull-request command on OS X. #1058

Closed
mattjmorrison opened this issue Dec 18, 2015 · 16 comments · Fixed by #1082
Closed

Trouble running pull-request command on OS X. #1058

mattjmorrison opened this issue Dec 18, 2015 · 16 comments · Fixed by #1082
Labels

Comments

@mattjmorrison
Copy link

I just installed hub from homebrew on OS X and I tried running hub pull-request. This is the message that I got:

└──➤ hub pull-request
github.com username: mattjmorrison
github.com password for mattjmorrison (never stored):
user: Current not implemented on darwin/amd64

I'm not sure what I'm doing wrong, but any help would be greatly appreciated.

Here are the versions that I'm working with:

└──➤ hub --version
git version 2.6.4
hub version 2.2.2
└──➤ sw_vers
ProductName:    Mac OS X
ProductVersion: 10.9.5
BuildVersion:   13F1134

Thanks!

@parkr
Copy link
Contributor

parkr commented Dec 18, 2015

Interesting! It looks like it's available for darwin under the general unix build flag. If you run brew remove hub && brew install hub --HEAD, does this fix itself?

@mattjmorrison
Copy link
Author

@parkr same result.

@parkr
Copy link
Contributor

parkr commented Dec 18, 2015

Hm, ok. It works just fine for me on Mac OS X 10.11.2. Perhaps 10.9.5 isn't yet compatible.

Dump this file into some go file in its own directory and execute go run <filename>. Does it error?

@mattjmorrison
Copy link
Author

@parkr I get a 404 on that file.

@parkr
Copy link
Contributor

parkr commented Dec 18, 2015

@mattjmorrison Sorry about that – please check the link again.

@mattjmorrison
Copy link
Author

Here is the result:

└──➤ go run lookup_user_unix.go
&{501 20 mattjmorrison mattjmorrison /Users/mattjmorrison} <nil>

@parkr
Copy link
Contributor

parkr commented Dec 18, 2015

If that works, then building from source should produce a binary of hub that works. I defer to mislav & co.

@mattjmorrison
Copy link
Author

@parkr building from source using these instructions: https://github.com/github/hub#source did seem to correct the problem - apparently it is something with the homebrew dist?

@parkr
Copy link
Contributor

parkr commented Dec 18, 2015

@mattjmorrison Perhaps! Glad you got it working. --HEAD should have built from the source, though. Maybe there was a cache or something lying around that was used instead. Hm!

@mislav
Copy link
Owner

mislav commented Dec 20, 2015

@mattjmorrison I'm glad you solved your problem, and sorry for the trouble. I don't know what causes this, but it seems like it's an incompatibility with pre-built binaries that we distribute with each release and OS X 10.9 😒

Thanks @parkr for help!

@owenthereal
Copy link
Contributor

The build process was recently changed since 2.2.2. I wonder if it's related to that. One way to find out would be to try out the OSX build of 2.2.1 and see if it works for OS X 10.9.5.

@buley
Copy link

buley commented Dec 25, 2015

There is at least one other go-enabled projects with a similar bug filed notaryproject/notary#194 (fix: notaryproject/notary#195). Possibly a Go error in finding the home directory on El Cap. Doesn't look like hub caching an oath token for anyone here so I'd look for it to be related to the lookup of the Github oauth token config file.

@buley
Copy link

buley commented Dec 29, 2015

Per @jingweno's comment, I've verified that the 2.2.1 binary works for me. brew ships 2.2.2. Workaround is to simply download and use the 2.2.1 Mac binary.

@mislav
Copy link
Owner

mislav commented Jan 19, 2016

We might need to pull in https://github.com/mitchellh/go-homedir as a workaround.

@owenthereal
Copy link
Contributor

Per @jingweno's comment, I've verified that the 2.2.1 binary works for me. brew ships 2.2.2. Workaround is to simply download and use the 2.2.1 Mac binary.

This could be a problem with the cross compile script or a miss in Go's cross compile capability. The 2.2.1 builds were compiled natively on different OSes.

@mislav
Copy link
Owner

mislav commented Jan 20, 2016

This is probably the same issue as #781. We will import go-homedir to solve this, but I'm wondering whether there will be other cgo incompatibilities in other code once execution is allowed to proceed past this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants