Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Selection of nodes and connections combined #188

Closed
jpk6789 opened this issue Jan 4, 2025 · 2 comments · Fixed by #189
Closed

[Feature] Selection of nodes and connections combined #188

jpk6789 opened this issue Jan 4, 2025 · 2 comments · Fixed by #189
Assignees
Labels
bug Something isn't working

Comments

@jpk6789
Copy link
Contributor

jpk6789 commented Jan 4, 2025

Is your feature request related to a problem? Please describe.
Currently, the selection of nodes and connections are treated as totally different processes. While this may have its use cases, I would prefer, that selecting a node deselects all connections and vice versa. Of course, if I press the shift or control key, I expect the current behavior of selecting multiple ones (nodes and connections).

Describe the solution you'd like
It would be nice, if there is at least an option to toggle between the current behavior and the described one here.

Describe alternatives you've considered
I would not change the default behavior as it would change the behavior of existing implementations.

@jpk6789 jpk6789 added the enhancement New feature or enhancement label Jan 4, 2025
@miroiu
Copy link
Owner

miroiu commented Jan 4, 2025

The behavior you described is actually the intended functionality. If treating node and connection selection as separate processes is needed, I believe that should be implemented as an optional feature controlled by a flag.

@miroiu miroiu added bug Something isn't working and removed enhancement New feature or enhancement labels Jan 4, 2025
@miroiu
Copy link
Owner

miroiu commented Jan 8, 2025

I merged the PR, but there are some improvements I will need to address in the future:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants