This repository has been archived by the owner on Oct 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 463
Localize the Flash On/Off button would be better #91
Comments
+1 on the above. I would even suggest an easier IMO approach - rather than localize the button, it can be replaced with icon pair Flash on / off. |
would be really awesome!! |
+1 |
3 similar comments
+1 |
+1 |
+1 |
I replaced flash toggle title by two icons in my fork. |
As mentioned here #131 (comment) I need to rewrite the platform communication. After that it's possible to use custom strings. |
Feel free to test: #185 |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The Flash On/Off button text is hard coded now, localize it would be better.
https://github.com/apptreesoftware/flutter_barcode_reader/blob/5d498e39a76466b03579486475ec777fba33ed2c/android/src/main/kotlin/com/apptreesoftware/barcodescan/BarcodeScannerActivity.kt#L39
https://github.com/apptreesoftware/flutter_barcode_reader/blob/5d498e39a76466b03579486475ec777fba33ed2c/android/src/main/kotlin/com/apptreesoftware/barcodescan/BarcodeScannerActivity.kt#L43
https://github.com/apptreesoftware/flutter_barcode_reader/blob/5e360fc9dad8f3525e75aaaf6e7d64490759eda2/ios/Classes/BarcodeScannerViewController.m#L93
https://github.com/apptreesoftware/flutter_barcode_reader/blob/5e360fc9dad8f3525e75aaaf6e7d64490759eda2/ios/Classes/BarcodeScannerViewController.m#L97
The text was updated successfully, but these errors were encountered: