From d9275e34b2a84fd6078578d4f402ec74558b5b12 Mon Sep 17 00:00:00 2001
From: dms1981 <david.sibley@digital.justice.gov.uk>
Date: Tue, 24 Sep 2024 17:27:04 +0100
Subject: [PATCH] Revert "Optionally output firewall logs to S3 bucket"

---
 terraform/modules/firewall-logging/main.tf      | 10 ----------
 terraform/modules/firewall-logging/variables.tf |  5 -----
 2 files changed, 15 deletions(-)

diff --git a/terraform/modules/firewall-logging/main.tf b/terraform/modules/firewall-logging/main.tf
index 95f10edd4..6103904c4 100644
--- a/terraform/modules/firewall-logging/main.tf
+++ b/terraform/modules/firewall-logging/main.tf
@@ -14,16 +14,6 @@ resource "aws_networkfirewall_logging_configuration" "main" {
       log_destination_type = "CloudWatchLogs"
       log_type             = "ALERT"
     }
-    dynamic "log_destination_config" {
-      for_each = var.s3_log_bucket != "" ? toset([var.s3_log_bucket]) : []
-      content {
-        log_destination = {
-          bucketName = log_destination_config.value
-        }
-        log_destination_type = "S3"
-        log_type             = "ALERT"
-      }
-    }
   }
 }
 
diff --git a/terraform/modules/firewall-logging/variables.tf b/terraform/modules/firewall-logging/variables.tf
index 5927b3579..35b8b49a5 100644
--- a/terraform/modules/firewall-logging/variables.tf
+++ b/terraform/modules/firewall-logging/variables.tf
@@ -7,11 +7,6 @@ variable "fw_arn" {
   description = "ARN of firewall for logging configuration"
   type        = string
 }
-variable "s3_log_bucket" {
-  description = "Optional ARN of an S3 bucket to ship logs to"
-  default     = ""
-  type        = string
-}
 
 variable "tags" {
   description = "A map of keys and values used to create resource metadata tags"