From 57841403705d29e4835c25d72aec9d27a4720e95 Mon Sep 17 00:00:00 2001
From: Arun Kumar Madesh <56151567+arunkumar461@users.noreply.github.com>
Date: Sat, 4 Jan 2025 10:40:52 +0000
Subject: [PATCH] CCMSPUI-468 | Refactor and Add tests

---
 .../dialect/DatePickerAttributes.java         | 19 +++++
 .../DatePickerElementTagProcessor.java        | 77 ++++++++++---------
 .../springboot/dialect/MojCustomDialect.java  |  6 +-
 .../MoJDatePickerElementTagProcessorTest.java | 31 +++++++-
 .../dialect/ThymeleafTestConfig.java          |  1 +
 .../resources/templates/test-datepicker.html  | 20 +++++
 6 files changed, 115 insertions(+), 39 deletions(-)
 create mode 100644 laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerAttributes.java
 create mode 100644 laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/resources/templates/test-datepicker.html

diff --git a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerAttributes.java b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerAttributes.java
new file mode 100644
index 0000000..fb07a90
--- /dev/null
+++ b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerAttributes.java
@@ -0,0 +1,19 @@
+package uk.gov.laa.ccms.springboot.dialect;
+
+/**
+ * DatePickerAttributes.
+ */
+public record DatePickerAttributes(
+    String id,
+    String name,
+    String label,
+    String hint,
+    String errorMessage,
+    String value,
+    String minDate,
+    String maxDate) {
+
+  public boolean hasError() {
+    return !errorMessage.isEmpty();
+  }
+}
diff --git a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerElementTagProcessor.java b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerElementTagProcessor.java
index d610ece..095b762 100644
--- a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerElementTagProcessor.java
+++ b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerElementTagProcessor.java
@@ -10,7 +10,7 @@
 import org.thymeleaf.templatemode.TemplateMode;
 
 /**
- * hello.
+ * Transforms <moj:datepicker/> elements into standard HTML button elements.
  */
 public class DatePickerElementTagProcessor extends AbstractElementTagProcessor {
 
@@ -26,74 +26,77 @@ protected void doProcess(ITemplateContext context, IProcessableElementTag tag,
                            IElementTagStructureHandler structureHandler) {
 
     Map<String, String> attributes = ProcessorUtils.parseAttributes(context, tag);
-
-    String id = attributes.getOrDefault("id", "date");
-    String name = attributes.getOrDefault("name", "date");
-    String value = attributes.get("value");
-    String label = attributes.getOrDefault("label", "Date");
-    String hint = attributes.getOrDefault("hint", "For example, 17/5/2024.");
-    String errorMessage = attributes.getOrDefault("errorMessage", "Enter or select a date");
-    String minDate = attributes.get("minDate");
-    String maxDate = attributes.get("maxDate");
-
-    boolean hasError = !errorMessage.isEmpty();
-
-    String datePickerHtml =
-        buildDatePickerHtml(id, name, label, hint, errorMessage, hasError, minDate, maxDate);
-
+    DatePickerAttributes datePickerAttributes = new DatePickerAttributes(
+        attributes.getOrDefault("id", "date"),
+        attributes.getOrDefault("name", "date"),
+        attributes.getOrDefault("label", "Date"),
+        attributes.get("hint"),
+        attributes.get("errorMessage"),
+        attributes.get("value"),
+        attributes.get("minDate"),
+        attributes.get("maxDate")
+    );
+
+    String datePickerHtml = buildDatePickerHtml(datePickerAttributes);
     final IModelFactory modelFactory = context.getModelFactory();
     final IModel model = modelFactory.parse(context.getTemplateData(), datePickerHtml);
     structureHandler.replaceWith(model, false);
 
   }
 
-  private String buildDatePickerHtml(String id, String name, String label, String hint,
-                                     String errorMessage, boolean hasError, String minDate,
-                                     String maxDate) {
+  private String buildDatePickerHtml(DatePickerAttributes datePickerAttributes) {
     StringBuilder html = new StringBuilder();
     html.append("<div class=\"moj-datepicker\" data-module=\"moj-date-picker\"");
 
-    if (!minDate.isEmpty()) {
-      html.append(" data-min-date=\"").append(minDate).append("\"");
+    if (!datePickerAttributes.minDate().isEmpty()) {
+      html.append(" data-min-date=\"").append(datePickerAttributes.minDate()).append("\"");
     }
-    if (!maxDate.isEmpty()) {
-      html.append(" data-max-date=\"").append(maxDate).append("\"");
+    if (!datePickerAttributes.maxDate().isEmpty()) {
+      html.append(" data-max-date=\"").append(datePickerAttributes.maxDate()).append("\"");
     }
 
     html.append(">")
         .append("<div class=\"govuk-form-group");
 
-    if (hasError) {
+    if (datePickerAttributes.hasError()) {
       html.append(" govuk-form-group--error");
     }
 
     html.append("\">")
-        .append("<label class=\"govuk-label\" for=\"").append(id).append("\">")
-        .append(label)
+        .append("<label class=\"govuk-label\" for=\"").append(datePickerAttributes.id())
+        .append("\">")
+        .append(datePickerAttributes.label())
         .append("</label>")
-        .append("<div id=\"").append(id).append("-hint\" class=\"govuk-hint\">")
-        .append(hint)
+        .append("<div id=\"").append(datePickerAttributes.id())
+        .append("-hint\" class=\"govuk-hint\">")
+        .append(datePickerAttributes.hint())
         .append("</div>");
 
-    if (hasError) {
-      html.append("<p id=\"").append(id).append("-error\" class=\"govuk-error-message\">")
+    if (datePickerAttributes.hasError()) {
+      html.append("<p id=\"").append(datePickerAttributes.id())
+          .append("-error\" class=\"govuk-error-message\">")
           .append("<span class=\"govuk-visually-hidden\">Error:</span> ")
-          .append(errorMessage)
+          .append(datePickerAttributes.errorMessage())
           .append("</p>");
     }
 
     html.append("<input class=\"govuk-input moj-js-datepicker-input");
 
-    if (hasError) {
+    if (datePickerAttributes.hasError()) {
       html.append(" govuk-input--error");
     }
 
-    html.append("\" id=\"").append(id)
-        .append("\" name=\"").append(name)
-        .append("\" type=\"text\" aria-describedby=\"").append(id).append("-hint");
+    html.append("\" id=\"").append(datePickerAttributes.id())
+        .append("\" name=\"").append(datePickerAttributes.name())
+        .append("\" type=\"text\" aria-describedby=\"").append(datePickerAttributes.id())
+        .append("-hint");
+
+    if (datePickerAttributes.hasError()) {
+      html.append(" ").append(datePickerAttributes.id()).append("-error");
+    }
 
-    if (hasError) {
-      html.append(" ").append(id).append("-error");
+    if (!datePickerAttributes.value().isEmpty()) {
+      html.append("\" value=\"").append(datePickerAttributes.value());
     }
 
     html.append("\" autocomplete=\"off\">")
diff --git a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/MojCustomDialect.java b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/MojCustomDialect.java
index 039129a..e139339 100644
--- a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/MojCustomDialect.java
+++ b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/MojCustomDialect.java
@@ -3,11 +3,15 @@
 import java.util.Set;
 import org.thymeleaf.dialect.AbstractProcessorDialect;
 import org.thymeleaf.processor.IProcessor;
+import org.thymeleaf.standard.StandardDialect;
 
+/**
+ * Develops a custom MoJ dialect.
+ */
 public class MojCustomDialect extends AbstractProcessorDialect {
 
   public MojCustomDialect() {
-    super("MOJ Custom Dialect", "moj", 1000);
+    super("MOJ Custom Dialect", "moj", StandardDialect.PROCESSOR_PRECEDENCE);
   }
 
   @Override
diff --git a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/java/uk/gov/laa/ccms/springboot/dialect/MoJDatePickerElementTagProcessorTest.java b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/java/uk/gov/laa/ccms/springboot/dialect/MoJDatePickerElementTagProcessorTest.java
index 09340b1..192e816 100644
--- a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/java/uk/gov/laa/ccms/springboot/dialect/MoJDatePickerElementTagProcessorTest.java
+++ b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/java/uk/gov/laa/ccms/springboot/dialect/MoJDatePickerElementTagProcessorTest.java
@@ -1,7 +1,36 @@
 package uk.gov.laa.ccms.springboot.dialect;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static org.assertj.core.api.Assertions.assertThat;
 
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.thymeleaf.context.Context;
+import org.thymeleaf.spring6.SpringTemplateEngine;
+
+@SpringBootTest(classes = ThymeleafTestConfig.class)
 class MoJDatePickerElementTagProcessorTest {
 
+  @Autowired
+  private SpringTemplateEngine templateEngine;
+
+  @Test
+  void shouldRenderGovukButton() {
+
+    Context context = new Context();
+    String renderedHtml = templateEngine.process("test-datepicker", context);
+    assertThat(renderedHtml)
+        .contains(
+            "<div class=\"moj-datepicker\" data-module=\"moj-date-picker\" data-min-date=\"2000-01-01\" " +
+                "data-max-date=\"2025-12-31\"><div class=\"govuk-form-group govuk-form-group--error\">" +
+                "<label class=\"govuk-label\" for=\"dob\">Date of Birth</label><div id=\"dob-hint\" " +
+                "class=\"govuk-hint\">For example, 01/01/2000.</div><p id=\"dob-error\" " +
+                "class=\"govuk-error-message\"><span class=\"govuk-visually-hidden\">Error:</span> " +
+                "Please enter a valid date of birth.</p><input class=\"govuk-input moj-js-datepicker-input " +
+                "govuk-input--error\" id=\"dob\" name=\"dateOfBirth\" type=\"text\" " +
+                "aria-describedby=\"dob-hint dob-error\" value=\"2024-01-01\" autocomplete=\"off\">" +
+                "</div></div>");
+
+  }
+
 }
\ No newline at end of file
diff --git a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/java/uk/gov/laa/ccms/springboot/dialect/ThymeleafTestConfig.java b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/java/uk/gov/laa/ccms/springboot/dialect/ThymeleafTestConfig.java
index dfe15d3..3f9107d 100644
--- a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/java/uk/gov/laa/ccms/springboot/dialect/ThymeleafTestConfig.java
+++ b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/java/uk/gov/laa/ccms/springboot/dialect/ThymeleafTestConfig.java
@@ -13,6 +13,7 @@ public class ThymeleafTestConfig {
   public SpringTemplateEngine testTemplateEngine() {
     SpringTemplateEngine templateEngine = new SpringTemplateEngine();
     templateEngine.addDialect(new GovUkDialect());
+    templateEngine.addDialect(new MojCustomDialect());
     templateEngine.addTemplateResolver(templateResolver());
     return templateEngine;
   }
diff --git a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/resources/templates/test-datepicker.html b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/resources/templates/test-datepicker.html
new file mode 100644
index 0000000..43dd98e
--- /dev/null
+++ b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/resources/templates/test-datepicker.html
@@ -0,0 +1,20 @@
+<!DOCTYPE html>
+<html xmlns:moj="http://www.thymeleaf.org" lang="EN">
+<head>
+    <title>Datepicker Test</title>
+</head>
+<body>
+
+<moj:datepicker
+        id="dob"
+        name="dateOfBirth"
+        label="Date of Birth"
+        hint="For example, 01/01/2000."
+        errorMessage="Please enter a valid date of birth."
+        minDate="2000-01-01"
+        maxDate="2025-12-31"
+        value="2024-01-01">
+</moj:datepicker>
+
+</body>
+</html>
\ No newline at end of file