New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine `Confirmation Time` column in `grin-wallet txs` #362

Open

lehnberg opened this issue Mar 9, 2020 · 0 comments

Labels

Collaborator

lehnberg commented Mar 9, 2020 •

edited

Loading

Steps to reproduce:

grin-wallet txs
In the output table, there's a column for "Confirmation time", providing a time stamp for when a transaction was confirmed.

Current behaviour:

The time stamp in "confirmation time" logs the time when the wallet realised that the transaction was confirmed, not necessarily when the transaction actually was confirmed on chain.

Expected behaviour:

The column should display information of when the transaction in question was confirmed on chain, for example by either:
- Providing the time stamp of the block that confirmed transaction; or
- Renaming Confirmation Time to Confirmed at height and instead providing the block height that confirmed the transaction.

The text was updated successfully, but these errors were encountered:

lehnberg added the enhancement label

deevope mentioned this issue

Add the parameter confirmed_height to retrieve_tx owner_api method #606

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment