Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings with AWS provider v4.6.0 #120

Closed
innomatics opened this issue Mar 29, 2022 · 2 comments · Fixed by #119
Closed

Warnings with AWS provider v4.6.0 #120

innomatics opened this issue Mar 29, 2022 · 2 comments · Fixed by #119
Labels
feature/terraform Missing feature from Terraform
Milestone

Comments

@innomatics
Copy link

Thank you for this excellent module ❤️ 🙏 happy to raise a PR if needed.

Module version: 12.0.9
Provider : hashicorp/aws 4.6.0
Terraform: 1.1.5

Output from terraform validate -json

{
  "format_version": "1.0",
  "valid": true,
  "error_count": 0,
  "warning_count": 2,
  "diagnostics": [
    {
      "severity": "warning",
      "summary": "Argument is deprecated",
      "detail": "Use the aws_s3_object resource instead",
      "address": "module.next_image_optimizer.module.image_optimizer.aws_s3_bucket_object.lambda_package",
      "range": {
        "filename": ".terraform/modules/next_image_optimizer.image_optimizer/main.tf",
        "start": {
          "line": 120,
          "column": 19,
          "byte": 5328
        },
        "end": {
          "line": 120,
          "column": 31,
          "byte": 5340
        }
      },
      "snippet": {
        "context": "resource \"aws_s3_bucket_object\" \"lambda_package\"",
        "code": "  key           = local.s3_key",
        "start_line": 120,
        "highlight_start_offset": 18,
        "highlight_end_offset": 30,
        "values": []
      }
    },
    {
      "severity": "warning",
      "summary": "Argument is deprecated",
      "detail": "Use the aws_s3_object resource instead",
      "address": "module.next_image_optimizer.module.image_optimizer.aws_s3_bucket_object.lambda_package",
      "range": {
        "filename": ".terraform/modules/next_image_optimizer.image_optimizer/main.tf",
        "start": {
          "line": 118,
          "column": 19,
          "byte": 5267
        },
        "end": {
          "line": 118,
          "column": 32,
          "byte": 5280
        }
      },
      "snippet": {
        "context": "resource \"aws_s3_bucket_object\" \"lambda_package\"",
        "code": "  bucket        = var.s3_bucket",
        "start_line": 118,
        "highlight_start_offset": 18,
        "highlight_end_offset": 31,
        "values": []
      }
    }
  ]
}
@ofhouse
Copy link
Member

ofhouse commented Mar 30, 2022

Hi, thanks for raising the issue.
Currently in the process to evaluate what needs to be changed to ensure compatibility with the 4.x provider.
Process is being tracked here: #119.

I plan to release it with the upcoming version 12.1.0 by the end of this week.

@ofhouse ofhouse added the feature/terraform Missing feature from Terraform label Mar 30, 2022
@ofhouse ofhouse added this to the Upcoming Iteration milestone Mar 30, 2022
@ofhouse
Copy link
Member

ofhouse commented Apr 4, 2022

Full support for AWS provider v4 has been released in v12.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/terraform Missing feature from Terraform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants