Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for water heaters #110

Open
lamerjack opened this issue Feb 29, 2024 · 9 comments
Open

Add support for water heaters #110

lamerjack opened this issue Feb 29, 2024 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lamerjack
Copy link

Not really an issue...
This control only air conditiorner?
I have a Midea/Comfee water heater that is remotable with smart home app.

@mill1000
Copy link
Owner

Only air conditioner for now.

To add support for another device type I need the protocol files and someone to be willing to run tests on the new code as it's developed.

To get the protocol files run:

msmart-ng download <device_ip>

If you're a HA user you may find this integration interesting as it supports more device types:
https://github.com/georgezhao2010/midea_ac_lan

@mill1000 mill1000 added enhancement New feature or request need more info Further information is requested labels Feb 29, 2024
@mill1000 mill1000 changed the title Works also with water heater. Add support for water heaters Feb 29, 2024
@lamerjack
Copy link
Author

Unfortunately i don't like HA, i like more Openhab...
here the result of the command:
rootto@Test:~$ msmart-ng download 172.24.74.68 INFO:msmart.cli:Discovering 172.24.74.68 on local network. INFO:msmart.cli:Found device: {'ip': '172.24.74.68', 'port': 6444, 'id': xxxxxxxxxxxxxxx, 'online': False, 'supported': False, 'type': 226, 'name': 'midea_e2_0584', 'sn': 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx', 'key': None, 'token': None} INFO:msmart.cloud:Using Midea cloud server: https://mp-prod.appsmb.com (China: False). INFO:msmart.cli:Downloading protocol from cloud. INFO:msmart.cli:Writing protocol to 'T_0000_E2_24.lua'. INFO:msmart.cli:Downloading plugin from cloud. INFO:msmart.cli:Writing plugin to '0xE2_2021122401.zip'

where i can upload the zip file?

ps this command say key and token 'none' but the command msmart-ng discover show correctly key and token
i'm not very skilled using python but with the right input i can do tests if necessary.

@mill1000
Copy link
Owner

mill1000 commented Mar 1, 2024

You can either post them to this issue or email them to me.

ps this command say key and token 'none' but the command msmart-ng discover show correctly key and token

This is simply because downloading the protocol doesn't require authenticating with the device. You will need that token and key to actually control the device.

@lamerjack
Copy link
Author

0xE2_2021122401.zip

sorry i didn't saw the attach button!

@mill1000
Copy link
Owner

mill1000 commented Mar 2, 2024

Thanks, I also need the Lua file too.

@lamerjack
Copy link
Author

Thanks, I also need the Lua file too.

T_0000_E2_24.zip
i had to zip it because was not supported as attach

@mill1000
Copy link
Owner

mill1000 commented Mar 5, 2024

Great. Thank you. I've created a branch and put these files there.

Can you provide screenshots of the OEM app?

What functionality are you looking for from the library? e.g.

  • Current water temperature
  • Target water temperature
  • Modes? e.g. Eco? Away? etc

@lamerjack
Copy link
Author

Hi. I'm looking for Just Current water temperature and Target water temperature.... and maybe ON OFF.
As attach the screenshots.

screenshots.zip
p.s.
how to use the branch that you create?

i suppose:
git clone -b feature/e2_device --single-branch https://github.com/mill1000/midea-msmart
cd midea-msmart
python3 -m pip install .

and then?

@mill1000
Copy link
Owner

mill1000 commented Mar 5, 2024

i suppose:
git clone -b feature/e2_device --single-branch https://github.com/mill1000/midea-msmart
cd midea-msmart
python3 -m pip install .

That should do it

and then?

Well I haven't written anything yet, so nothing can be done for now.

@mill1000 mill1000 removed the need more info Further information is requested label Mar 5, 2024
@mill1000 mill1000 added the help wanted Extra attention is needed label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants